1417 completion timeout (#2374)

* Refactor handleDefaultStreamResponseV2 function for better error handling

* run yarn lint

* small error handling changes

* update error handling flow and scope of vars

* add back space

---------

Co-authored-by: Roman <rrojaski@gmail.com>
This commit is contained in:
Timothy Carambat 2024-09-25 14:00:19 -07:00 committed by GitHub
parent e6c4eb3f1c
commit 44dddcd4af
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -22,41 +22,55 @@ function handleDefaultStreamResponseV2(response, stream, responseProps) {
const handleAbort = () => clientAbortedHandler(resolve, fullText); const handleAbort = () => clientAbortedHandler(resolve, fullText);
response.on("close", handleAbort); response.on("close", handleAbort);
for await (const chunk of stream) { // Now handle the chunks from the streamed response and append to fullText.
const message = chunk?.choices?.[0]; try {
const token = message?.delta?.content; for await (const chunk of stream) {
const message = chunk?.choices?.[0];
const token = message?.delta?.content;
if (token) { if (token) {
fullText += token; fullText += token;
writeResponseChunk(response, { writeResponseChunk(response, {
uuid, uuid,
sources: [], sources: [],
type: "textResponseChunk", type: "textResponseChunk",
textResponse: token, textResponse: token,
close: false, close: false,
error: false, error: false,
}); });
} }
// LocalAi returns '' and others return null on chunks - the last chunk is not "" or null. // LocalAi returns '' and others return null on chunks - the last chunk is not "" or null.
// Either way, the key `finish_reason` must be present to determine ending chunk. // Either way, the key `finish_reason` must be present to determine ending chunk.
if ( if (
message?.hasOwnProperty("finish_reason") && // Got valid message and it is an object with finish_reason message?.hasOwnProperty("finish_reason") && // Got valid message and it is an object with finish_reason
message.finish_reason !== "" && message.finish_reason !== "" &&
message.finish_reason !== null message.finish_reason !== null
) { ) {
writeResponseChunk(response, { writeResponseChunk(response, {
uuid, uuid,
sources, sources,
type: "textResponseChunk", type: "textResponseChunk",
textResponse: "", textResponse: "",
close: true, close: true,
error: false, error: false,
}); });
response.removeListener("close", handleAbort); response.removeListener("close", handleAbort);
resolve(fullText); resolve(fullText);
break; // Break streaming when a valid finish_reason is first encountered break; // Break streaming when a valid finish_reason is first encountered
}
} }
} catch (e) {
console.log(`\x1b[43m\x1b[34m[STREAMING ERROR]\x1b[0m ${e.message}`);
writeResponseChunk(response, {
uuid,
type: "abort",
textResponse: null,
sources: [],
close: true,
error: e.message,
});
resolve(fullText); // Return what we currently have - if anything.
} }
}); });
} }