From 6279941b7333caac2b962144880e4f652d6d0d2d Mon Sep 17 00:00:00 2001 From: timothycarambat Date: Fri, 7 Jun 2024 13:19:33 -0700 Subject: [PATCH] Refactor file search method and implementation --- frontend/package.json | 3 +- .../Documents/Directory/index.jsx | 40 +++------------ .../Documents/Directory/utils.js | 49 +++++++++++++++++++ .../Modals/ManageWorkspace/index.jsx | 12 +++-- frontend/src/index.css | 4 ++ .../WorkspaceSettings/AgentConfig/index.jsx | 7 ++- frontend/yarn.lock | 5 ++ 7 files changed, 80 insertions(+), 40 deletions(-) create mode 100644 frontend/src/components/Modals/ManageWorkspace/Documents/Directory/utils.js diff --git a/frontend/package.json b/frontend/package.json index 8aa4dcfa..84c27166 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -19,6 +19,7 @@ "file-saver": "^2.0.5", "he": "^1.2.0", "highlight.js": "^11.9.0", + "js-levenshtein": "^1.1.6", "lodash.debounce": "^4.0.8", "markdown-it": "^13.0.1", "pluralize": "^8.0.0", @@ -63,4 +64,4 @@ "tailwindcss": "^3.3.1", "vite": "^4.3.0" } -} \ No newline at end of file +} diff --git a/frontend/src/components/Modals/ManageWorkspace/Documents/Directory/index.jsx b/frontend/src/components/Modals/ManageWorkspace/Documents/Directory/index.jsx index 7dc4cfb9..c7794a3f 100644 --- a/frontend/src/components/Modals/ManageWorkspace/Documents/Directory/index.jsx +++ b/frontend/src/components/Modals/ManageWorkspace/Documents/Directory/index.jsx @@ -12,6 +12,7 @@ import { useModal } from "@/hooks/useModal"; import ModalWrapper from "@/components/ModalWrapper"; import NewFolderModal from "./NewFolderModal"; import debounce from "lodash.debounce"; +import { filterFileSearchResults } from "./utils"; function Directory({ files, @@ -30,7 +31,6 @@ function Directory({ const [amountSelected, setAmountSelected] = useState(0); const [showFolderSelection, setShowFolderSelection] = useState(false); const [searchTerm, setSearchTerm] = useState(""); - const [isSearching, setIsSearching] = useState(false); const { isOpen: isFolderModalOpen, openModal: openFolderModal, @@ -166,34 +166,12 @@ function Directory({ setLoading(false); }; - const filterFiles = (item) => { - if (item.type === "folder") { - return ( - item.name.toLowerCase().includes(searchTerm.toLowerCase()) || - item.items.some((file) => - file.name.toLowerCase().includes(searchTerm.toLowerCase()) - ) - ); - } else { - return item.name.toLowerCase().includes(searchTerm.toLowerCase()); - } - }; - - const debouncedSearch = debounce((value) => { - setSearchTerm(value); - setIsSearching(false); - }, 500); - - const handleSearch = (e) => { + const handleSearch = debounce((e) => { const searchValue = e.target.value; setSearchTerm(searchValue); - setIsSearching(true); - debouncedSearch(searchValue); - }; - - const filteredFiles = - files && files.items ? files.items.filter((item) => filterFiles(item)) : []; + }, 500); + const filteredFiles = filterFileSearchResults(files, searchTerm); return (
@@ -201,10 +179,10 @@ function Directory({

My Documents

- ) : isSearching && searchTerm !== "" ? ( -
- -
) : filteredFiles.length > 0 ? ( filteredFiles.map( (item, index) => diff --git a/frontend/src/components/Modals/ManageWorkspace/Documents/Directory/utils.js b/frontend/src/components/Modals/ManageWorkspace/Documents/Directory/utils.js new file mode 100644 index 00000000..1bea2615 --- /dev/null +++ b/frontend/src/components/Modals/ManageWorkspace/Documents/Directory/utils.js @@ -0,0 +1,49 @@ +import strDistance from "js-levenshtein"; + +const LEVENSHTEIN_MIN = 8; + +// Regular expression pattern to match the v4 UUID and the ending .json +const uuidPattern = + /-[a-f0-9]{8}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{4}-[a-f0-9]{12}/; +const jsonPattern = /\.json$/; + +// Function to strip UUID v4 and JSON from file names as that will impact search results. +const stripUuidAndJsonFromString = (input = "") => { + return input + ?.replace(uuidPattern, "") // remove v4 uuid + ?.replace(jsonPattern, "") // remove trailing .json + ?.replace("-", " "); // turn slugged names into spaces +}; + +export function filterFileSearchResults(files = [], searchTerm = "") { + if (!searchTerm) return files?.items || []; + + const searchResult = []; + for (const folder of files?.items) { + // If folder is a good match then add all its children + if (strDistance(folder.name, searchTerm) <= LEVENSHTEIN_MIN) { + searchResult.push(folder); + continue; + } + + // Otherwise check children for good results + const fileSearchResults = []; + for (const file of folder?.items) { + if ( + strDistance(stripUuidAndJsonFromString(file.name), searchTerm) <= + LEVENSHTEIN_MIN + ) { + fileSearchResults.push(file); + } + } + + if (fileSearchResults.length > 0) { + searchResult.push({ + ...folder, + items: fileSearchResults, + }); + } + } + + return searchResult; +} diff --git a/frontend/src/components/Modals/ManageWorkspace/index.jsx b/frontend/src/components/Modals/ManageWorkspace/index.jsx index 56b9b50b..2c6e658b 100644 --- a/frontend/src/components/Modals/ManageWorkspace/index.jsx +++ b/frontend/src/components/Modals/ManageWorkspace/index.jsx @@ -8,7 +8,7 @@ import useUser from "../../../hooks/useUser"; import DocumentSettings from "./Documents"; import DataConnectors from "./DataConnectors"; -const noop = () => { }; +const noop = () => {}; const ManageWorkspace = ({ hideModal = noop, providedSlug = null }) => { const { slug } = useParams(); const { user } = useUser(); @@ -105,19 +105,21 @@ const ModalTabSwitcher = ({ selectedTab, setSelectedTab }) => {
diff --git a/frontend/src/index.css b/frontend/src/index.css index 35159b3f..f3fa95ea 100644 --- a/frontend/src/index.css +++ b/frontend/src/index.css @@ -742,3 +742,7 @@ does not extend the close button beyond the viewport. */ opacity: 0; } } + +.search-input::-webkit-search-cancel-button { + filter: grayscale(100%) invert(1) brightness(100) opacity(0.5); +} diff --git a/frontend/src/pages/WorkspaceSettings/AgentConfig/index.jsx b/frontend/src/pages/WorkspaceSettings/AgentConfig/index.jsx index 9fb6f5d7..0b31b9ae 100644 --- a/frontend/src/pages/WorkspaceSettings/AgentConfig/index.jsx +++ b/frontend/src/pages/WorkspaceSettings/AgentConfig/index.jsx @@ -144,7 +144,12 @@ function LoadingSkeleton() { ); } -function AvailableAgentSkills({ skills, settings, toggleAgentSkill, setHasChanges }) { +function AvailableAgentSkills({ + skills, + settings, + toggleAgentSkill, + setHasChanges, +}) { return (
diff --git a/frontend/yarn.lock b/frontend/yarn.lock index 93bdc088..d5bdc0d6 100644 --- a/frontend/yarn.lock +++ b/frontend/yarn.lock @@ -2260,6 +2260,11 @@ jiti@^1.19.1: resolved "https://registry.yarnpkg.com/jiti/-/jiti-1.21.0.tgz#7c97f8fe045724e136a397f7340475244156105d" integrity sha512-gFqAIbuKyyso/3G2qhiO2OM6shY6EPP/R0+mkDbyspxKazh8BXDC5FiFsUjlczgdNz/vfra0da2y+aHrusLG/Q== +js-levenshtein@^1.1.6: + version "1.1.6" + resolved "https://registry.yarnpkg.com/js-levenshtein/-/js-levenshtein-1.1.6.tgz#c6cee58eb3550372df8deb85fad5ce66ce01d59d" + integrity sha512-X2BB11YZtrRqY4EnQcLX5Rh373zbK4alC1FW7D7MBhL2gtcC17cTnr6DmfHZeS0s2rTHjUTMMHfG7gO8SSdw+g== + "js-tokens@^3.0.0 || ^4.0.0", js-tokens@^4.0.0: version "4.0.0" resolved "https://registry.yarnpkg.com/js-tokens/-/js-tokens-4.0.0.tgz#19203fb59991df98e3a287050d4647cdeaf32499"