2016-02-03 14:48:40 +01:00
|
|
|
#!/bin/bash
|
2014-05-28 09:28:28 +02:00
|
|
|
#
|
2015-01-09 15:36:17 +01:00
|
|
|
# Simple pre-commit hook to check that there are no errors in the fdroidserver
|
|
|
|
# source files.
|
2014-05-28 09:28:28 +02:00
|
|
|
|
|
|
|
# Redirect output to stderr.
|
|
|
|
exec 1>&2
|
|
|
|
|
2016-02-03 14:48:40 +01:00
|
|
|
files=`git diff-index --cached HEAD 2>&1 | sed 's/^:.* //' | uniq | cut -b100-500`
|
2016-02-15 13:01:43 +01:00
|
|
|
if [ -z "$files" ]; then
|
2021-06-01 15:02:32 +02:00
|
|
|
PY_FILES="fdroid makebuildserver setup.py fdroidserver/*.py examples/*.py tests/*-release-checksums.py"
|
2016-02-03 14:48:40 +01:00
|
|
|
PY_TEST_FILES="tests/*.TestCase"
|
|
|
|
SH_FILES="hooks/pre-commit"
|
2018-07-11 11:40:28 +02:00
|
|
|
BASH_FILES="gradlew-fdroid jenkins-build-all jenkins-setup-build-environment jenkins-test completion/bash-completion buildserver/provision-*"
|
2016-09-12 13:05:05 +02:00
|
|
|
RB_FILES="buildserver/Vagrantfile"
|
2023-04-21 09:10:04 +02:00
|
|
|
YML_FILES=".*.yml .yamllint */*.yml */*.yaml"
|
2016-02-03 14:48:40 +01:00
|
|
|
else
|
|
|
|
# if actually committing right now, then only run on the files
|
|
|
|
# that are going to be committed at this moment
|
|
|
|
PY_FILES=
|
|
|
|
PY_TEST_FILES=
|
|
|
|
SH_FILES=
|
|
|
|
BASH_FILES=
|
|
|
|
RB_FILES=
|
2020-10-22 23:34:47 +02:00
|
|
|
YML_FILES=
|
2016-02-03 14:48:40 +01:00
|
|
|
|
|
|
|
for f in $files; do
|
2016-06-15 13:32:14 +02:00
|
|
|
test -e $f || continue
|
2016-02-03 14:48:40 +01:00
|
|
|
case $f in
|
|
|
|
*.py)
|
|
|
|
PY_FILES+=" $f"
|
|
|
|
;;
|
|
|
|
*.TestCase)
|
|
|
|
PY_TEST_FILES+=" $f"
|
|
|
|
;;
|
|
|
|
*.rb)
|
|
|
|
RB_FILES+=" $f"
|
|
|
|
;;
|
2023-04-21 09:10:04 +02:00
|
|
|
*.yml|.*.yml|.yamllint)
|
2020-10-22 23:34:47 +02:00
|
|
|
YML_FILES+=" $f"
|
|
|
|
;;
|
2016-02-03 14:48:40 +01:00
|
|
|
*)
|
|
|
|
if head -1 $f | grep '^#!/bin/sh' > /dev/null 2>&1; then
|
|
|
|
SH_FILES+=" $f"
|
|
|
|
elif head -1 $f | grep '^#!/bin/bash' > /dev/null 2>&1; then
|
|
|
|
BASH_FILES+=" $f"
|
|
|
|
elif head -1 $f | grep '^#!.*python' > /dev/null 2>&1; then
|
|
|
|
PY_FILES+=" $f"
|
|
|
|
fi
|
|
|
|
;;
|
|
|
|
esac
|
|
|
|
done
|
|
|
|
fi
|
2014-05-28 09:28:28 +02:00
|
|
|
|
2014-11-09 14:34:24 +01:00
|
|
|
err() {
|
2016-07-13 13:07:03 +02:00
|
|
|
echo >&2 ERROR: "$@"
|
2014-11-09 14:34:24 +01:00
|
|
|
exit 1
|
|
|
|
}
|
|
|
|
|
2016-02-15 16:25:43 +01:00
|
|
|
warn() {
|
2016-07-13 13:07:03 +02:00
|
|
|
echo >&2 WARNING: "$@"
|
2016-02-15 16:25:43 +01:00
|
|
|
}
|
|
|
|
|
2014-05-28 09:28:28 +02:00
|
|
|
cmd_exists() {
|
|
|
|
command -v $1 1>/dev/null
|
|
|
|
}
|
|
|
|
|
2016-01-15 00:19:11 +01:00
|
|
|
find_command() {
|
2016-07-13 13:14:19 +02:00
|
|
|
for name in $@; do
|
2017-11-27 14:32:41 +01:00
|
|
|
for suff in "3" "-3" "-python3" ""; do
|
2016-07-13 13:14:19 +02:00
|
|
|
cmd=${name}${suff}
|
|
|
|
if cmd_exists $cmd; then
|
|
|
|
echo $cmd
|
|
|
|
return 0
|
|
|
|
fi
|
|
|
|
done
|
2016-01-15 00:19:11 +01:00
|
|
|
done
|
|
|
|
warn "$1 is not installed, using dummy placeholder!"
|
2016-07-13 13:14:19 +02:00
|
|
|
echo :
|
2016-01-15 00:19:11 +01:00
|
|
|
}
|
2014-05-28 09:28:28 +02:00
|
|
|
|
2017-12-04 12:10:46 +01:00
|
|
|
DASH=$(find_command dash)
|
2023-04-21 09:40:57 +02:00
|
|
|
PYDOCSTYLE=$(find_command pydocstyle)
|
2016-01-15 00:19:11 +01:00
|
|
|
PYFLAKES=$(find_command pyflakes)
|
2023-05-04 16:12:08 +02:00
|
|
|
PYCODESTYLE=$(find_command pycodestyle pep8)
|
2017-12-04 12:10:46 +01:00
|
|
|
RUBY=$(find_command ruby)
|
2020-10-22 23:34:47 +02:00
|
|
|
YAMLLINT=$(find_command yamllint)
|
2014-05-28 09:28:28 +02:00
|
|
|
|
2016-02-12 00:27:17 +01:00
|
|
|
if [ "$PY_FILES $PY_TEST_FILES" != " " ]; then
|
2016-02-03 14:48:40 +01:00
|
|
|
if ! $PYFLAKES $PY_FILES $PY_TEST_FILES; then
|
2014-11-09 14:36:58 +01:00
|
|
|
err "pyflakes tests failed!"
|
2016-02-03 14:48:40 +01:00
|
|
|
fi
|
2023-04-21 09:40:57 +02:00
|
|
|
if ! $PYDOCSTYLE $PY_FILES $PY_TEST_FILES; then
|
|
|
|
err "pydocstyle tests failed!"
|
|
|
|
fi
|
2014-11-09 14:36:58 +01:00
|
|
|
fi
|
|
|
|
|
2016-02-12 00:27:17 +01:00
|
|
|
if [ "$PY_FILES" != "" ]; then
|
2023-05-04 16:12:08 +02:00
|
|
|
if ! $PYCODESTYLE $PY_FILES; then
|
2014-11-09 14:36:58 +01:00
|
|
|
err "pep8 tests failed!"
|
2016-02-03 14:48:40 +01:00
|
|
|
fi
|
2014-11-09 14:36:58 +01:00
|
|
|
fi
|
2014-09-18 19:56:11 +02:00
|
|
|
|
2016-02-12 00:27:17 +01:00
|
|
|
if [ "$PY_TEST_FILES" != "" ]; then
|
2023-05-04 16:12:08 +02:00
|
|
|
if ! $PYCODESTYLE $PY_TEST_FILES; then
|
2015-09-01 20:10:01 +02:00
|
|
|
err "pep8 tests failed!"
|
2016-02-03 14:48:40 +01:00
|
|
|
fi
|
2015-09-01 20:10:01 +02:00
|
|
|
fi
|
|
|
|
|
2014-11-09 14:31:50 +01:00
|
|
|
for f in $SH_FILES; do
|
2017-12-04 12:10:46 +01:00
|
|
|
if ! $DASH -n $f; then
|
2015-01-09 16:08:27 +01:00
|
|
|
err "dash tests failed!"
|
|
|
|
fi
|
|
|
|
done
|
|
|
|
|
|
|
|
for f in $BASH_FILES; do
|
2014-11-09 14:36:58 +01:00
|
|
|
if ! bash -n $f; then
|
|
|
|
err "bash tests failed!"
|
|
|
|
fi
|
2014-09-18 19:56:11 +02:00
|
|
|
done
|
|
|
|
|
2014-12-12 12:34:28 +01:00
|
|
|
for f in $RB_FILES; do
|
2017-12-04 12:10:46 +01:00
|
|
|
if ! $RUBY -c $f 1>/dev/null; then
|
2014-12-12 12:34:28 +01:00
|
|
|
err "ruby tests failed!"
|
|
|
|
fi
|
|
|
|
done
|
|
|
|
|
2020-10-22 23:34:47 +02:00
|
|
|
for f in $YML_FILES; do
|
2023-04-21 09:10:04 +02:00
|
|
|
if ! $YAMLLINT $f; then
|
2020-10-22 23:34:47 +02:00
|
|
|
err ".yml tests failed on $f!"
|
|
|
|
fi
|
|
|
|
done
|
|
|
|
|
2018-05-28 09:44:57 +02:00
|
|
|
if grep -C 3 'shell=True' fdroidserver/[a-ce-z]*.py; then
|
2018-01-23 23:56:15 +01:00
|
|
|
err "shell=True is too dangerous, there are unfiltered user inputs!"
|
|
|
|
fi
|
|
|
|
|
2014-11-09 14:34:24 +01:00
|
|
|
exit 0
|