kamp/fdroidserver
1
0
Fork 0
mirror of https://gitlab.com/fdroid/fdroidserver.git synced 2024-11-16 11:50:10 +01:00
Code Activity
aeb8a7a3e5
fdroidserver/tests/net.TestCase

143 lines
4.7 KiB
Plaintext
Raw Normal View History

net: improve parsing filenames from URL This is more relevant to issuebot than fdroidserver, but it can't hurt here also.
2022-05-09 18:51:41 +02:00
#!/usr/bin/env python3
import inspect
import logging
import os
net: add test of automatic retries in download_file() The existing logic from d1ddd525c in !1225 is confusing because it adds its own retry loop on top of the retry mechanism that is built into requests. So this test confirms that setting `download_file(retries=3)` actually results in more than three retries.
2024-02-26 11:46:08 +01:00
import random
import requests
import socket
net: improve parsing filenames from URL This is more relevant to issuebot than fdroidserver, but it can't hurt here also.
2022-05-09 18:51:41 +02:00
import sys
import tempfile
net: add test of automatic retries in download_file() The existing logic from d1ddd525c in !1225 is confusing because it adds its own retry loop on top of the retry mechanism that is built into requests. So this test confirms that setting `download_file(retries=3)` actually results in more than three retries.
2024-02-26 11:46:08 +01:00
import threading
import time
net: improve parsing filenames from URL This is more relevant to issuebot than fdroidserver, but it can't hurt here also.
2022-05-09 18:51:41 +02:00
import unittest
from unittest.mock import MagicMock, patch
localmodule = os.path.realpath(
os.path.join(os.path.dirname(inspect.getfile(inspect.currentframe())), '..')
)
print('localmodule: ' + localmodule)
if localmodule not in sys.path:
sys.path.insert(0, localmodule)
from fdroidserver import common, net
from pathlib import Path
net: add test of automatic retries in download_file() The existing logic from d1ddd525c in !1225 is confusing because it adds its own retry loop on top of the retry mechanism that is built into requests. So this test confirms that setting `download_file(retries=3)` actually results in more than three retries.
2024-02-26 11:46:08 +01:00
class RetryServer:
"""A stupid simple HTTP server that can fail to connect"""
def __init__(self, port=None, failures=3):
self.port = port
if self.port is None:
self.port = random.randint(1024, 65535)
self.failures = failures
self.stop_event = threading.Event()
threading.Thread(target=self.run_fake_server).start()
def stop(self):
self.stop_event.set()
def run_fake_server(self):
server_sock = socket.socket()
server_sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
server_sock.bind(('127.0.0.1', self.port))
server_sock.listen(5)
server_sock.settimeout(5)
time.sleep(0.001) # wait for it to start
while not self.stop_event.is_set():
self.failures -= 1
conn = None
try:
conn, address = server_sock.accept()
conn.settimeout(5)
except TimeoutError:
break
if self.failures > 0:
conn.close()
continue
conn.recv(8192) # request ignored
self.reply = b"""HTTP/1.1 200 OK
Date: Mon, 26 Feb 2024 09:00:14 GMT
Connection: close
Content-Type: text/html
<HTML><BODY>Hello World!</HEAD></HTML>
"""
self.reply = self.reply.replace(b' ', b'') # dedent
conn.sendall(self.reply)
conn.shutdown(socket.SHUT_RDWR)
conn.close()
self.stop_event.wait(timeout=1)
server_sock.shutdown(socket.SHUT_RDWR)
server_sock.close()
net: improve parsing filenames from URL This is more relevant to issuebot than fdroidserver, but it can't hurt here also.
2022-05-09 18:51:41 +02:00
class NetTest(unittest.TestCase):
basedir = Path(__file__).resolve().parent
def setUp(self):
logging.basicConfig(level=logging.DEBUG)
self.tempdir = tempfile.TemporaryDirectory()
os.chdir(self.tempdir.name)
Path('tmp').mkdir()
def tearDown(self):
self.tempdir.cleanup()
@patch('requests.get')
def test_download_file_url_parsing(self, requests_get):
enable black on tests: api, gpgsign, main, net, vcs
2023-04-24 12:59:53 +02:00
# pylint: disable=unused-argument
def _get(url, stream, allow_redirects, headers, timeout):
net: improve parsing filenames from URL This is more relevant to issuebot than fdroidserver, but it can't hurt here also.
2022-05-09 18:51:41 +02:00
return MagicMock()
requests_get.side_effect = _get
use tiny entry.jar rather than large index-v1.jar for net test case
2024-02-26 11:18:08 +01:00
f = net.download_file('https://f-droid.org/repo/entry.jar', retries=0)
net: fix test_download_file_url_parsing self.assertTrue(requests_get.called) will always be true because .called will contain a MagicMock instance.
2024-02-27 16:35:56 +01:00
requests_get.assert_called()
net: improve parsing filenames from URL This is more relevant to issuebot than fdroidserver, but it can't hurt here also.
2022-05-09 18:51:41 +02:00
self.assertTrue(os.path.exists(f))
use tiny entry.jar rather than large index-v1.jar for net test case
2024-02-26 11:18:08 +01:00
self.assertEqual('tmp/entry.jar', f)
net: improve parsing filenames from URL This is more relevant to issuebot than fdroidserver, but it can't hurt here also.
2022-05-09 18:51:41 +02:00
f = net.download_file(
net.download_file(): retry on errors
2022-10-22 23:15:13 +02:00
'https://d-05.example.com/custom/com.downloader.aegis-3175421.apk?_fn=QVBLUHVyZV92My4xNy41NF9hcGtwdXJlLmNvbS5hcGs&_p=Y29tLmFwa3B1cmUuYWVnb24&am=6avvTpfJ1dMl9-K6JYKzQw&arg=downloader%3A%2F%2Fcampaign%2F%3Futm_medium%3Ddownloader%26utm_source%3Daegis&at=1652080635&k=1f6e58465df3a441665e585719ab0b13627a117f&r=https%3A%2F%2Fdownloader.com%2Fdownloader-app.html%3Ficn%3Daegis%26ici%3Dimage_qr&uu=http%3A%2F%2F172.16.82.1%2Fcustom%2Fcom.downloader.aegis-3175421.apk%3Fk%3D3fb9c4ae0be578206f6a1c330736fac1627a117f',
enable black on tests: api, gpgsign, main, net, vcs
2023-04-24 12:59:53 +02:00
retries=0,
net: improve parsing filenames from URL This is more relevant to issuebot than fdroidserver, but it can't hurt here also.
2022-05-09 18:51:41 +02:00
)
self.assertTrue(requests_get.called)
self.assertTrue(os.path.exists(f))
self.assertEqual('tmp/com.downloader.aegis-3175421.apk', f)
net: add test of automatic retries in download_file() The existing logic from d1ddd525c in !1225 is confusing because it adds its own retry loop on top of the retry mechanism that is built into requests. So this test confirms that setting `download_file(retries=3)` actually results in more than three retries.
2024-02-26 11:46:08 +01:00
def test_download_file_retries(self):
server = RetryServer()
f = net.download_file('http://localhost:%d/f.txt' % server.port)
# strip the HTTP headers and compare the reply
self.assertEqual(server.reply.split(b'\n\n')[1], Path(f).read_bytes())
server.stop()
def test_download_file_retries_not_forever(self):
"""The retry logic should eventually exit with an error."""
server = RetryServer(failures=5)
with self.assertRaises(requests.exceptions.ConnectionError):
net.download_file('http://localhost:%d/f.txt' % server.port)
server.stop()
net: improve parsing filenames from URL This is more relevant to issuebot than fdroidserver, but it can't hurt here also.
2022-05-09 18:51:41 +02:00
if __name__ == "__main__":
os.chdir(os.path.dirname(__file__))
remove all references to optparse (deprecated since Python 3.2)
2024-05-02 14:08:28 +02:00
import argparse
parser = argparse.ArgumentParser()
parser.add_argument(
net: improve parsing filenames from URL This is more relevant to issuebot than fdroidserver, but it can't hurt here also.
2022-05-09 18:51:41 +02:00
"-v",
"--verbose",
action="store_true",
default=False,
help="Spew out even more information than normal",
)
split out options from read_config() There is no longer any reason for these to be intertwined. This deliberately avoids touching some files as much as possible because they are super tangled and due to be replaced. Those files are: * fdroidserver/build.py * fdroidserver/update.py # Conflicts: # tests/testcommon.py # Conflicts: # fdroidserver/btlog.py # fdroidserver/import_subcommand.py
2024-05-08 16:26:46 +02:00
common.options = common.parse_args(parser)
net: improve parsing filenames from URL This is more relevant to issuebot than fdroidserver, but it can't hurt here also.
2022-05-09 18:51:41 +02:00
newSuite = unittest.TestSuite()
newSuite.addTest(unittest.makeSuite(NetTest))
unittest.main(failfast=False)
Copy Permalink