kamp/fdroidserver
1
0
Fork 0
mirror of https://gitlab.com/fdroid/fdroidserver.git synced 2024-10-02 17:20:25 +02:00
Code Activity

pylint flags "_" as bad variable name, its the gettext function

Browse Source 
Throughout the fdroidserver code base, "_()" is used for localizing
strings.  So it should not be used as an ignored variable name.  Those
should be called "_ignored".
This commit is contained in:
Hans-Christoph Steiner 2021-02-12 10:51:26 +01:00
parent fb877c8b81
commit 007c62065d
No known key found for this signature in database
GPG Key ID: 3E177817BA1B9BFA
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.pylint-rcfile
View File

@ -35,7 +35,7 @@ notes=FIXME,XXX,TODO
[BASIC] [BASIC]
# Good variable names which should always be accepted, separated by a comma # Good variable names which should always be accepted, separated by a comma
good-names=i,j,k,ex,Run,_,e,f,fp good-names=i,j,k,ex,Run,f,fp
[ELIF] [ELIF]

2
fdroidserver/index.py
View File

@ -142,7 +142,7 @@ def _should_file_be_generated(path, magic_string):
def make_website(apps, repodir, repodict): def make_website(apps, repodir, repodict):
_, repo_pubkey_fingerprint = extract_pubkey() _ignored, repo_pubkey_fingerprint = extract_pubkey()
repo_pubkey_fingerprint_stripped = repo_pubkey_fingerprint.replace(" ", "") repo_pubkey_fingerprint_stripped = repo_pubkey_fingerprint.replace(" ", "")
link = repodict["address"] link = repodict["address"]
link_fingerprinted = "{link}?fingerprint={fingerprint}".format(link=link, fingerprint=repo_pubkey_fingerprint_stripped) link_fingerprinted = "{link}?fingerprint={fingerprint}".format(link=link, fingerprint=repo_pubkey_fingerprint_stripped)