Adapt scanner, fix some other issues

completion/bash-completion

@@ -82,6 +82,9 @@ __complete_build() {
 	lopts="--help --verbose --latest --server --resetserver --on-server
  --force --all"
 	case "${cur}" in
+		-*)
+			__complete_options
+			return 0;;
 		*:)
 			__vercode
 			return 0;;
@@ -89,7 +92,6 @@ __complete_build() {
 			__package
 			return 0;;
 	esac
-	__complete_options
 }
 
 __complete_install() {
@@ -175,14 +177,19 @@ __complete_rewritemeta() {
 }
 
 __complete_scanner() {
-	opts="-h -v -p"
+	opts="-h -v"
-	lopts="--help --verbose --package --nosvn"
+	lopts="--help --verbose --nosvn"
-	case "${prev}" in
+	case "${cur}" in
-		-p|--package)
+		-*)
+			__complete_options
+			return 0;;
+		*:)
+			__vercode
+			return 0;;
+		*)
 			__package
 			return 0;;
 	esac
-	__complete_options
 }
 
 __complete_verify() {

fdroidserver/rewritemeta.py

@@ -30,7 +30,7 @@ def main():
     global config, options
 
     # Parse command line...
-    parser = OptionParser()
+    parser = OptionParser(usage="Usage: %prog [options] [APPID [APPID ...]]")
     parser.add_option("-v", "--verbose", action="store_true", default=False,
                       help="Spew out even more information than normal")
     (options, args) = parser.parse_args()
@@ -41,13 +41,9 @@ def main():
     allapps = metadata.read_metadata(xref=False)
     apps = common.read_app_args(args, allapps, False)
 
-    if len(apps) == 0:
-        print "No packages to rewrite"
-        sys.exit(1)
-
     for app in apps:
         print "Writing " + app['id']
-        metadata.write_metadata(os.path.join('metadata', app['id']) + '.txt', app)
+        metadata.write_metadata(os.path.join('metadata', app['id'])+'.txt', app)
 
     print "Finished."
 

fdroidserver/scanner.py

@@ -33,7 +33,7 @@ def main():
     global config, options
 
     # Parse command line...
-    parser = OptionParser()
+    parser = OptionParser(usage="Usage: %prog [options] [APPID[:VERCODE] [APPID[:VERCODE] ...]]")
     parser.add_option("-v", "--verbose", action="store_true", default=False,
                       help="Spew out even more information than normal")
     parser.add_option("-p", "--package", default=None,
@@ -45,14 +45,8 @@ def main():
     config = common.read_config(options)
 
     # Get all apps...
-    apps = metadata.read_metadata()
+    allapps = metadata.read_metadata()
-
+    apps = common.read_app_args(args, allapps, True)
-    # Filter apps according to command-line options
-    if options.package:
-        apps = [app for app in apps if app['id'] == options.package]
-        if len(apps) == 0:
-            print "No such package"
-            sys.exit(1)
 
     problems = []
 
@@ -68,51 +62,49 @@ def main():
         skip = False
         if app['Disabled']:
             print "Skipping %s: disabled" % app['id']
-            skip = True
+            continue
-        elif not app['builds']:
+        if not app['builds']:
             print "Skipping %s: no builds specified" % app['id']
-            skip = True
+            continue
         elif options.nosvn and app['Repo Type'] == 'svn':
-            skip = True
+            continue
 
-        if not skip:
+        print "Processing " + app['id']
 
-            print "Processing " + app['id']
+        try:
 
-            try:
+            build_dir = 'build/' + app['id']
 
-                build_dir = 'build/' + app['id']
+            # Set up vcs interface and make sure we have the latest code...
+            vcs = common.getvcs(app['Repo Type'], app['Repo'], build_dir)
 
-                # Set up vcs interface and make sure we have the latest code...
+            for thisbuild in app['builds']:
-                vcs = common.getvcs(app['Repo Type'], app['Repo'], build_dir)
 
-                for thisbuild in app['builds']:
+                if 'disable' in thisbuild:
+                    print ("..skipping version " + thisbuild['version'] + " - " +
+                            thisbuild.get('disable', thisbuild['commit'][1:]))
+                else:
+                    print "..scanning version " + thisbuild['version']
 
-                    if 'disable' in thisbuild:
+                    # Prepare the source code...
-                        print ("..skipping version " + thisbuild['version'] + " - " +
+                    root_dir, _ = common.prepare_source(vcs, app, thisbuild,
-                                thisbuild.get('disable', thisbuild['commit'][1:]))
+                            build_dir, srclib_dir, extlib_dir, False)
-                    else:
-                        print "..scanning version " + thisbuild['version']
 
-                        # Prepare the source code...
+                    # Do the scan...
-                        root_dir, _ = common.prepare_source(vcs, app, thisbuild,
+                    buildprobs = common.scan_source(build_dir, root_dir, thisbuild)
-                                build_dir, srclib_dir, extlib_dir, False)
+                    for problem in buildprobs:
+                        problems.append(problem + 
+                            ' in ' + app['id'] + ' ' + thisbuild['version'])
 
-                        # Do the scan...
+        except BuildException as be:
-                        buildprobs = common.scan_source(build_dir, root_dir, thisbuild)
+            msg = "Could not scan app %s due to BuildException: %s" % (app['id'], be)
-                        for problem in buildprobs:
+            problems.append(msg)
-                            problems.append(problem + 
+        except VCSException as vcse:
-                                ' in ' + app['id'] + ' ' + thisbuild['version'])
+            msg = "VCS error while scanning app %s: %s" % (app['id'], vcse)
-
+            problems.append(msg)
-            except BuildException as be:
+        except Exception:
-                msg = "Could not scan app %s due to BuildException: %s" % (app['id'], be)
+            msg = "Could not scan app %s due to unknown error: %s" % (app['id'], traceback.format_exc())
-                problems.append(msg)
+            problems.append(msg)
-            except VCSException as vcse:
-                msg = "VCS error while scanning app %s: %s" % (app['id'], vcse)
-                problems.append(msg)
-            except Exception:
-                msg = "Could not scan app %s due to unknown error: %s" % (app['id'], traceback.format_exc())
-                problems.append(msg)
 
     print "Finished:"
     for problem in problems: