From 0da8c2c36591c02aafcbe90254ba335d55798ef3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Tue, 26 Aug 2014 13:31:31 +0200 Subject: [PATCH] lint: fix duplicate usage of appid --- fdroidserver/lint.py | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/fdroidserver/lint.py b/fdroidserver/lint.py index 30a1807c..9c0dcfdc 100644 --- a/fdroidserver/lint.py +++ b/fdroidserver/lint.py @@ -128,16 +128,16 @@ regex_pedantic = { def main(): - global config, options, appid, count - appid = None + global config, options, curid, count + curid = None count = Counter() def warn(message): - global appid, count - if appid: - print "%s:" % appid - appid = None + global curid, count + if curid: + print "%s:" % curid + curid = None count['app'] += 1 print ' %s' % message count['warn'] += 1 @@ -163,6 +163,7 @@ def main(): apps = common.read_app_args(args, allapps, False) for appid, app in apps.iteritems(): + curid = appid lastcommit = '' if app['Disabled']: @@ -240,7 +241,7 @@ def main(): # TODO: This should not be pedantic! pwarn("'%s' used in %s '%s'" % (s, flag, build[flag])) - if not appid: + if not curid: print logging.info("Found a total of %i warnings in %i apps." % (count['warn'], count['app']))