From 11f4165f374cee7e6fc6b7964bfd5fe304841d60 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Tue, 19 Nov 2013 15:47:53 +0100 Subject: [PATCH] Properly convert boolean strings to bools as before --- fdroidserver/metadata.py | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/fdroidserver/metadata.py b/fdroidserver/metadata.py index f02079be..904dd134 100644 --- a/fdroidserver/metadata.py +++ b/fdroidserver/metadata.py @@ -107,15 +107,19 @@ valuetypes = { def check_metadata(info): for k, t in valuetypes.iteritems(): - for field in [f for f in t.fields if f in info]: - t.check(info[field], info['id']) - if k == 'Bool': - info[field] = info[field] == "Yes" + for field in t.fields: + if field in info: + t.check(info[field], info['id']) + if k == 'Bool': + info[field] = info[field] == "Yes" for build in info['builds']: - for attr in [a for a in t.attrs if a in build]: - t.check(build[attr], info['id']) - if k == 'bool': - info[field] = info[field] == "yes" + for attr in t.attrs: + if attr in build: + t.check(build[attr], info['id']) + if k == 'bool': + build[attr] = build[attr] == "yes" + elif k == 'bool': + build[attr] = False # Formatter for descriptions. Create an instance, and call parseline() with # each line of the description source from the metadata. At the end, call