kamp/fdroidserver
1
0
Fork 0
mirror of https://gitlab.com/fdroid/fdroidserver.git synced 2024-08-17 20:00:10 +02:00
Code Activity

lint: catch more incorrect lists

Browse Source
This commit is contained in:
Daniel Martí 2015-08-31 15:25:41 -07:00
parent 12926420a6
commit 23794446f7
1 changed files with 13 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
fdroidserver/lint.py
View File

@ -260,28 +260,30 @@ def main():
or any(not desc[l - 1] and not desc[l] for l in range(1, len(desc)))):
warn("Description has an extra empty line")
# Check for lists using the wrong characters
validchars = ['*', '#']
lchar = ''
lcount = 0
for l in app['Description']:
if len(l) < 1:
continue
for um in desc_url.finditer(l):
url = um.group(1)
for m, r in http_warnings:
if m.match(url):
warn("URL '%s' in Description: %s" % (url, r))
c = l.decode('utf-8')[0]
if c == lchar:
# Check for lists using the wrong characters
validchars = ['*', '#']
lchar = ''
lcount = 0
for l in app['Description']:
if len(l) < 1:
lcount = 0
continue
ld = l.decode('utf-8')
if ld[0] == lchar and ld[1] == ' ':
lcount += 1
if lcount > 3 and lchar not in validchars:
if lcount > 2 and lchar not in validchars:
warn("Description has a list (%s) but it isn't bulleted (*) nor numbered (#)" % lchar)
break
else:
lchar = c
lchar = ld[0]
lcount = 1
# Regex checks in all kinds of fields