kamp/fdroidserver
1
0
Fork 0
mirror of https://gitlab.com/fdroid/fdroidserver.git synced 2024-11-20 13:50:12 +01:00
Code Activity

Deploy build error log in case of an exception

Browse Source 
This happened with us.spotco.fennec_dos_2912000 where no build log was
saved in the repo but the wiki has an error text. The error text was:

"Command '['rsync', '--recursive', '--perms', '--links', '--quiet', '--rsh=ssh -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null -o LogLevel=FATAL -o IdentitiesOnly=yes -o PasswordAuthentication=no -p 2222 -i /home/fbuild/.vagrant.d/boxes/buildserver/0/virtualbox/vagrant_private_key', 'build/srclib/MozFennec', 'vagrant@127.0.0.1:/home/vagrant/build/srclib']' returned non-zero exit status 255."

Which is generated by the rsync subprocess call in build_server(). I
assume that it threw an Exception (not an FdroidException, because the
string "Build completed at" is not in the wiki site) that was caught in
main().
This commit is contained in:
Jochen Sprickerhof 2021-08-27 08:05:28 +02:00
parent 7c88bb09a5
commit 23b0b6bcaf
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fdroidserver/build.py
View File

@ -1228,6 +1228,7 @@ def main():
common.force_exit(1) common.force_exit(1)
add_failed_builds_entry(failed_builds, appid, build, e) add_failed_builds_entry(failed_builds, appid, build, e)
wikilog = e.get_wikitext() wikilog = e.get_wikitext()
common.deploy_build_log_with_rsync(appid, build.versionCode, str(e))
except Exception as e: except Exception as e:
logging.error("Could not build app %s due to unknown error: %s" % ( logging.error("Could not build app %s due to unknown error: %s" % (
appid, traceback.format_exc())) appid, traceback.format_exc()))
@ -1236,6 +1237,7 @@ def main():
common.force_exit(1) common.force_exit(1)
add_failed_builds_entry(failed_builds, appid, build, e) add_failed_builds_entry(failed_builds, appid, build, e)
wikilog = str(e) wikilog = str(e)
common.deploy_build_log_with_rsync(appid, build.versionCode, str(e))
if options.wiki and wikilog: if options.wiki and wikilog:
try: try: