kamp/fdroidserver
1
0
Fork 0
mirror of https://gitlab.com/fdroid/fdroidserver.git synced 2024-11-09 00:40:11 +01:00
Code Activity

lint: require UpdateCheckData to contain only valid HTTPS URLs

Browse Source
This commit is contained in:
Hans-Christoph Steiner 2018-03-01 23:29:38 +01:00
parent 1c9bc32bf6
commit 26bfd7fb28
1 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
fdroidserver/lint.py
View File

@ -21,6 +21,7 @@ import glob
import os import os
import re import re
import sys import sys
import urllib.parse
from . import _ from . import _
from . import common from . import common
@ -207,6 +208,19 @@ def get_lastbuild(builds):
return lastbuild return lastbuild
def check_update_check_data_url(app):
"""UpdateCheckData must have a valid HTTPS URL to protect checkupdates runs
"""
if app.UpdateCheckData:
urlcode, codeex, urlver, verex = app.UpdateCheckData.split('|')
for url in (urlcode, urlver):
parsed = urllib.parse.urlparse(url)
if not parsed.scheme or not parsed.netloc:
yield _('UpdateCheckData not a valid URL: {url}').format(url=url)
if parsed.scheme != 'https':
yield _('UpdateCheckData must use HTTPS URL: {url}').format(url=url)
def check_ucm_tags(app): def check_ucm_tags(app):
lastbuild = get_lastbuild(app.builds) lastbuild = get_lastbuild(app.builds)
if (lastbuild is not None if (lastbuild is not None
@ -513,6 +527,7 @@ def main():
app_check_funcs = [ app_check_funcs = [
check_regexes, check_regexes,
check_update_check_data_url,
check_ucm_tags, check_ucm_tags,
check_char_limits, check_char_limits,
check_old_links, check_old_links,