Fix several read_metadata-related issues

Various calls with the wrong parameters, and also an unused parameter on
the function itself.

fdroidserver/checkupdates.py

@@ -329,7 +329,7 @@ def main():
     config = common.read_config(options)
 
     # Get all apps...
-    allapps = metadata.read_metadata(options.verbose)
+    allapps = metadata.read_metadata()
 
     apps = common.read_app_args(args, allapps, False)
 

fdroidserver/metadata.py

@@ -422,7 +422,7 @@ def parse_srclib(metafile, **kw):
 
 # Read all metadata. Returns a list of 'app' objects (which are dictionaries as
 # returned by the parse_metadata function.
-def read_metadata(xref=True, package=None, store=True):
+def read_metadata(xref=True, package=None):
     apps = []
 
     for basedir in ('metadata', 'tmp'):

fdroidserver/readmeta.py

@@ -26,7 +26,7 @@ def main():
     if not os.path.isdir('metadata'):
         return
 
-    metadata.read_metadata(xref=False, store=False)
+    metadata.read_metadata(xref=True)
 
 if __name__ == "__main__":
     main()

fdroidserver/rewritemeta.py

@@ -42,7 +42,7 @@ def main():
     config = common.read_config(options)
 
     # Get all apps...
-    allapps = metadata.read_metadata(xref=False)
+    allapps = metadata.read_metadata(xref=True)
     apps = common.read_app_args(args, allapps, False)
 
     for app in apps:

fdroidserver/stats.py

@@ -71,7 +71,7 @@ def main():
         sys.exit(1)
 
     # Get all metadata-defined apps...
-    metaapps = metadata.read_metadata(options.verbose)
+    metaapps = metadata.read_metadata()
 
     statsdir = 'stats'
     logsdir = os.path.join(statsdir, 'logs')