From 3d50ecf5fe8d3445f136e603917b3afa3d98efc8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Tue, 26 Aug 2014 13:40:18 +0200 Subject: [PATCH] Don't accept empty commits With SCMs like git, "git checkout ''" doesn't actually fail, so one may commit builds without noticing that they left the commit empty. --- fdroidserver/metadata.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fdroidserver/metadata.py b/fdroidserver/metadata.py index c6a4db0a..7672de68 100644 --- a/fdroidserver/metadata.py +++ b/fdroidserver/metadata.py @@ -679,7 +679,8 @@ def parse_metadata(metafile): line = line.rstrip('\r\n') if mode == 3: if not any(line.startswith(s) for s in (' ', '\t')): - if 'commit' not in curbuild and 'disable' not in curbuild: + commit = curbuild['commit'] if 'commit' in curbuild else None + if not commit and 'disable' not in curbuild: raise MetaDataException("No commit specified for {0} in {1}" .format(curbuild['version'], linedesc))