From cf54c9514c2b0be004f23d79eb4ef99e68ce8860 Mon Sep 17 00:00:00 2001 From: csagan5 <32685696+csagan5@users.noreply.github.com> Date: Tue, 30 Jan 2018 14:50:35 +0100 Subject: [PATCH 1/2] Option --resetserver does nothing; have it used instead --- fdroidserver/build.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fdroidserver/build.py b/fdroidserver/build.py index 116da5bb..ca0ccc73 100644 --- a/fdroidserver/build.py +++ b/fdroidserver/build.py @@ -73,7 +73,7 @@ def build_server(app, build, vcs, build_dir, output_dir, log_dir, force): else: logging.getLogger("paramiko").setLevel(logging.WARN) - sshinfo = vmtools.get_clean_builder('builder') + sshinfo = vmtools.get_clean_builder('builder', options.resetserver) try: if not buildserverid: From 427427481e04c5388d91f70ea1ff7869d8a95e79 Mon Sep 17 00:00:00 2001 From: csagan5 <32685696+csagan5@users.noreply.github.com> Date: Tue, 30 Jan 2018 20:45:03 +0100 Subject: [PATCH 2/2] Change --resetserver to --reset-server for consistency --- completion/bash-completion | 2 +- fdroidserver/build.py | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/completion/bash-completion b/completion/bash-completion index 28588656..2d413641 100644 --- a/completion/bash-completion +++ b/completion/bash-completion @@ -90,7 +90,7 @@ __complete_options() { __complete_build() { opts="-v -q -l -s -t -f -a -w" - lopts="--verbose --quiet --latest --stop --test --server --resetserver + lopts="--verbose --quiet --latest --stop --test --server --reset-server --on-server --skip-scan --no-tarball --force --all --wiki --no-refresh" case "${cur}" in -*) diff --git a/fdroidserver/build.py b/fdroidserver/build.py index ca0ccc73..0b575847 100644 --- a/fdroidserver/build.py +++ b/fdroidserver/build.py @@ -73,7 +73,7 @@ def build_server(app, build, vcs, build_dir, output_dir, log_dir, force): else: logging.getLogger("paramiko").setLevel(logging.WARN) - sshinfo = vmtools.get_clean_builder('builder', options.resetserver) + sshinfo = vmtools.get_clean_builder('builder', options.reset_server) try: if not buildserverid: @@ -935,7 +935,7 @@ def parse_commandline(): help=_("Test mode - put output in the tmp directory only, and always build, even if the output already exists.")) parser.add_argument("--server", action="store_true", default=False, help=_("Use build server")) - parser.add_argument("--resetserver", action="store_true", default=False, + parser.add_argument("--reset-server", action="store_true", default=False, help=_("Reset and create a brand new build server, even if the existing one appears to be ok.")) parser.add_argument("--on-server", dest="onserver", action="store_true", default=False, help=_("Specify that we're running on the build server")) @@ -1005,8 +1005,8 @@ def main(): if config['build_server_always']: options.server = True - if options.resetserver and not options.server: - parser.error("option %s: Using --resetserver without --server makes no sense" % "resetserver") + if options.reset_server and not options.server: + parser.error("option %s: Using --reset-server without --server makes no sense" % "reset-server") log_dir = 'logs' if not os.path.isdir(log_dir):