From 5346ea3c19279f667c1c933fcdf29aa0f665c8b1 Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Wed, 14 Apr 2021 22:54:48 +0200 Subject: [PATCH] gitlab-ci: prevent dualing linters: pyflakes vs mypy * pyflakes says: "typing.Dict' imported but unused" * mypy says: "Name 'Dict' is not defined" --- .gitlab-ci.yml | 3 ++- fdroidserver/apksigcopier.py | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 3310b410..1f02ba77 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -193,7 +193,8 @@ lint_mypy: script: - pip install mypy - pip install -e .[test] - - mypy + # exclude vendored file + - mypy --exclude fdroidserver/apksigcopier.py fedora_latest: image: fedora:latest diff --git a/fdroidserver/apksigcopier.py b/fdroidserver/apksigcopier.py index 48b72ce1..bb4e9b22 100644 --- a/fdroidserver/apksigcopier.py +++ b/fdroidserver/apksigcopier.py @@ -96,7 +96,7 @@ class ZipError(APKSigCopierError): class ReproducibleZipInfo(zipfile.ZipInfo): """Reproducible ZipInfo hack.""" - _override = {} # type: Dict[str, Any] + _override = {} def __init__(self, zinfo, **override): if override: