From 580ce8541227327ea0f42cac8ef6b7c3e19df2ae Mon Sep 17 00:00:00 2001 From: FestplattenSchnitzel Date: Wed, 14 Sep 2022 11:52:49 +0200 Subject: [PATCH] [lint] Fix comparisons in check_updates_expected --- fdroidserver/lint.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fdroidserver/lint.py b/fdroidserver/lint.py index ffef8bd6..685bda54 100644 --- a/fdroidserver/lint.py +++ b/fdroidserver/lint.py @@ -664,8 +664,10 @@ def check_current_version_code(app): def check_updates_expected(app): """Check if update checking makes sense.""" - if (app.get('NoSourceSince') or app.get('ArchivePolicy') == '0 versions') and ( - app.get('AutoUpdateMode') or app.get('UpdateCheckMode') + if ( + app.get('NoSourceSince') or app.get('ArchivePolicy') == '0 versions' + ) and not all( + app.get(key, 'None') == 'None' for key in ('AutoUpdateMode', 'UpdateCheckMode') ): yield _( 'App has NoSourceSince or ArchivePolicy "0 versions" but AutoUpateMode or UpdateCheck are not None'