From 7544761e86cb5e4a25c6c81bb3634212da31ec6d Mon Sep 17 00:00:00 2001
From: Hans-Christoph Steiner <hans@eds.org>
Date: Tue, 7 Jun 2022 13:15:36 +0200
Subject: [PATCH] index: add test for --nosign config and file generation

---
 tests/index.TestCase | 43 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 43 insertions(+)

diff --git a/tests/index.TestCase b/tests/index.TestCase
index b101eb46..23b0560d 100755
--- a/tests/index.TestCase
+++ b/tests/index.TestCase
@@ -359,6 +359,49 @@ class IndexTest(unittest.TestCase):
         )
         self.assertTrue(os.path.exists(os.path.join('repo', 'index.xml')))
 
+    def test_v0_invalid_config_exception(self):
+        """Index v0 needs additional config values when using --nosign
+
+        index.xml aka Index v0 includes the full repo public key in
+        the XML itself.  So when running `fdroid update --nosign`,
+        there needs to be either repo_pubkey or a full keystore config
+        present.
+
+        """
+        tmptestsdir = tempfile.mkdtemp(
+            prefix=inspect.currentframe().f_code.co_name, dir=self.tmpdir
+        )
+        os.chdir(tmptestsdir)
+        os.mkdir('repo')
+        repo_icons_dir = os.path.join('repo', 'icons')
+        self.assertFalse(os.path.isdir(repo_icons_dir))
+        repodict = {
+            'address': 'https://example.com/fdroid/repo',
+            'description': 'This is just a test',
+            'icon': 'blahblah',
+            'name': 'test',
+            'timestamp': datetime.datetime.now(),
+            'version': 12,
+        }
+        requestsdict = {'install': [], 'uninstall': []}
+
+        fdroidserver.common.options.nosign = False
+        with self.assertRaises(fdroidserver.exception.FDroidException):
+            fdroidserver.index.make_v0({}, [], 'repo', repodict, requestsdict, {})
+
+        fdroidserver.common.options.nosign = True
+        with self.assertRaises(fdroidserver.exception.FDroidException):
+            fdroidserver.index.make_v0({}, [], 'repo', repodict, requestsdict, {})
+
+        fdroidserver.common.config['repo_pubkey'] = 'ffffffffffffffffffffffffffffffffff'
+        self.assertFalse(os.path.exists(os.path.join('repo', 'index.xml')))
+        self.assertFalse(os.path.exists(os.path.join('repo', 'index_unsigned.jar')))
+        self.assertFalse(os.path.exists(os.path.join('repo', 'index.jar')))
+        fdroidserver.index.make_v0({}, [], 'repo', repodict, requestsdict, {})
+        self.assertTrue(os.path.exists(os.path.join('repo', 'index.xml')))
+        self.assertTrue(os.path.exists(os.path.join('repo', 'index_unsigned.jar')))
+        self.assertFalse(os.path.exists(os.path.join('repo', 'index.jar')))
+
     def test_github_get_mirror_service_urls(self):
         for url in [
             'git@github.com:foo/bar',