From 785df58e9a4d639a330f67a37f5a00cb29084853 Mon Sep 17 00:00:00 2001 From: Ciaran Gultnieks Date: Wed, 22 Feb 2012 15:28:59 +0000 Subject: [PATCH] Revert "SparkleShare: Add patch to allow install on camera-less devices." This reverts commit 998d42fd4e84afa09a2803dc25d61437d042a6d5. There doesn't seem to be any point in patching this: a) It's already been in the repo a long time b) If we issue another version of a package, with the exact same version name and code, how is anybody supposed to know which is which? (I realise in this case it wouldn't make much difference, but the general principle is important) c) There is a technical problem in that if a different version of what should be the same apk is pushed to the repo, installations will be rejected by the client (until an update is done) because they will see that the file they download is not what it was supposed to be. d) The developer says he is fixing it in the next release anyway. --- metadata/org.sparkleshare.android.txt | 2 +- .../org.sparkleshare.android/uses-feature.patch | 16 ---------------- 2 files changed, 1 insertion(+), 17 deletions(-) delete mode 100644 metadata/org.sparkleshare.android/uses-feature.patch diff --git a/metadata/org.sparkleshare.android.txt b/metadata/org.sparkleshare.android.txt index b3141435..b6896eb0 100644 --- a/metadata/org.sparkleshare.android.txt +++ b/metadata/org.sparkleshare.android.txt @@ -16,7 +16,7 @@ browse your files right from your Android device. Repo Type:git Repo:https://github.com/NewProggie/SparkleShare-Android.git -Build Version:1.0,1,a9e23f0f9ae6161a786bf48cb48ab3dec20110c9,patch=uses-feature.patch,target=android-7 +Build Version:1.0,1,a9e23f0f9ae6161a786bf48cb48ab3dec20110c9,target=android-7 Update Check Mode:Market Current Version:1.0 diff --git a/metadata/org.sparkleshare.android/uses-feature.patch b/metadata/org.sparkleshare.android/uses-feature.patch deleted file mode 100644 index fe29960d..00000000 --- a/metadata/org.sparkleshare.android/uses-feature.patch +++ /dev/null @@ -1,16 +0,0 @@ -Camera use is optional, don't disallow install on camera-less devices. -See right side pane at -http://developer.android.com/guide/topics/manifest/uses-permission-element.html - -diff --git a/AndroidManifest.xml b/AndroidManifest.xml -index d020d9d..1b45bf1 100644 ---- a/AndroidManifest.xml -+++ b/AndroidManifest.xml -@@ -8,6 +8,7 @@ - - - -+ -