From 8ccc89ad4eed06a8ddd61ccba85590f9727f590d Mon Sep 17 00:00:00 2001 From: Hans-Christoph Steiner Date: Fri, 5 May 2023 10:47:27 +0200 Subject: [PATCH] index: fix requestsdict check order of operations If requestsdict is None, the old logic would still check requestsdict["uninstall"]) and crash there. --- fdroidserver/index.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fdroidserver/index.py b/fdroidserver/index.py index d93ec586..162472ed 100644 --- a/fdroidserver/index.py +++ b/fdroidserver/index.py @@ -735,7 +735,7 @@ def make_v2(apps, packages, repodir, repodict, requestsdict, fdroid_signing_key_ output = collections.OrderedDict() output["repo"] = v2_repo(repodict, repodir, archive) - if requestsdict and requestsdict["install"] or requestsdict["uninstall"]: + if requestsdict and (requestsdict["install"] or requestsdict["uninstall"]): output["repo"]["requests"] = requestsdict # establish sort order of the index