kamp/fdroidserver
1
0
Fork 0
mirror of https://gitlab.com/fdroid/fdroidserver.git synced 2024-11-09 00:40:11 +01:00
Code Activity

Issue warnings for debuggable apks

Browse Source
This commit is contained in:
Ciaran Gultnieks 2013-04-15 13:04:13 +01:00
parent ce19ba1c29
commit 94a33f0a04
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
fdroidserver/common.py
View File

@ -2180,3 +2180,19 @@ class KnownApks:
lst.reverse() lst.reverse()
return lst return lst
def isApkDebuggable(apkfile):
"""Returns True if the given apk file is debuggable"""
p = subprocess.Popen([os.path.join(sdk_path, 'platform-tools', 'aapt'),
'dump', 'xmltree', apkfile, 'AndroidManifest.xml'],
stdout=subprocess.PIPE)
output = p.communicate()[0]
if p.returncode != 0:
print "ERROR: Failed to get apk manifest information"
sys.exit(1)
for line in output.splitlines():
if line.find('android:debuggable') != -1 and not line.endswith('0x0'):
return True
return False

4
fdroidserver/update.py
View File

@ -329,6 +329,10 @@ def main():
print " WARNING: no SDK version information found" print " WARNING: no SDK version information found"
thisinfo['sdkversion'] = 0 thisinfo['sdkversion'] = 0
# Check for debuggable apks...
if common.isApkDebuggable(apkfile):
print "WARNING: {0} is debuggable... {1}".format(apkfile, line)
# Calculate the md5 and sha256... # Calculate the md5 and sha256...
m = hashlib.md5() m = hashlib.md5()
sha = hashlib.sha256() sha = hashlib.sha256()