pylint: Reenable C0201 consider-iterating-dictionary

* C0201: Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary)

fdroidserver/__main__.py

@@ -134,7 +134,7 @@ def main():
         sys.exit(0)
 
     command = sys.argv[1]
-    if command not in COMMANDS and command not in available_plugins.keys():
+    if command not in COMMANDS and command not in available_plugins:
         if command in ('-h', '--help'):
             print_help(available_plugins=available_plugins)
             sys.exit(0)

fdroidserver/metadata.py

@@ -504,8 +504,8 @@ def parse_yaml_srclib(metadatapath):
                                cause=e)
             return thisinfo
 
-    for key in data.keys():
+    for key in data:
-        if key not in thisinfo.keys():
+        if key not in thisinfo:
             _warn_or_exception(_("Invalid srclib metadata: unknown key "
                                  "'{key}' in '{file}'")
                                .format(key=key, file=metadatapath))

makebuildserver

@@ -312,7 +312,7 @@ def main():
                                              version=config['basebox_version']))
                     sys.exit(1)
             # verify box
-            if config['basebox_version'] not in BASEBOX_CHECKSUMS.keys():
+            if config['basebox_version'] not in BASEBOX_CHECKSUMS:
                 logging.critical("can not verify '{box}', "
                                  "unknown basebox version '{version}'"
                                  .format(box=config['basebox'],

pyproject.toml

@@ -61,7 +61,6 @@ confidence = ["HIGH", "INFERENCE"]
 disable = [
   "broad-exception-caught",
   "broad-exception-raised",
-  "consider-iterating-dictionary",
   "invalid-name",
   "missing-class-docstring",
   "missing-function-docstring",