kamp/fdroidserver
1
0
Fork 0
mirror of https://gitlab.com/fdroid/fdroidserver.git synced 2024-11-19 21:30:10 +01:00
Code Activity

git-svn: require working HTTPS for all Subversion URLs

Browse Source 
Subversion does not verify each commit as strongly as git does, so HTTPS is
really important.  Also, there is the possibility of injecting code into
`fdroid checkupdate` calls if plain HTTP is used.
This commit is contained in:
Hans-Christoph Steiner 2018-02-05 14:43:39 +01:00
parent dd93ee6c9b
commit a1075f45cc
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fdroidserver/common.py
View File

@ -1004,6 +1004,9 @@ class vcs_gitsvn(vcs):
else: else:
remote = self.remote remote = self.remote
if not remote.startswith('https://'):
raise VCSException(_('HTTPS must be used with Subversion URLs!'))
gitsvn_args.extend(['--', remote, self.local]) gitsvn_args.extend(['--', remote, self.local])
p = self.git(gitsvn_args) p = self.git(gitsvn_args)
if p.returncode != 0: if p.returncode != 0: