From a3e082ab7fa36a08a6caf4ce16fc6d81b18a4e36 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Mon, 17 Jun 2013 18:15:11 +0200 Subject: [PATCH] Create comma-separated lists in the Python way --- fdroidserver/update.py | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/fdroidserver/update.py b/fdroidserver/update.py index ee25daf6..ce1934fe 100644 --- a/fdroidserver/update.py +++ b/fdroidserver/update.py @@ -528,19 +528,10 @@ def make_index(apps, apks, repodir, archive, categories): if 'added' in apk: addElement('added', time.strftime('%Y-%m-%d', apk['added']), doc, apkel) perms = "" - for p in apk['permissions']: - if len(perms) > 0: - perms += "," - perms += p - if len(perms) > 0: - addElement('permissions', perms, doc, apkel) - features = "" - for f in apk['features']: - if len(features) > 0: - features += "," - features += f - if len(features) > 0: - addElement('features', features, doc, apkel) + if len(apk['permissions']) > 0: + addElement('permissions', ','.join(apk['permissions']), doc, apkel) + if len(apk['features') > 0: + addElement('features', ','.join(apk['features']), doc, apkel) of = open(os.path.join(repodir, 'index.xml'), 'wb') if options.pretty: