From b86d815743c0deef2a2ae9f01e91f39de610dfec Mon Sep 17 00:00:00 2001 From: Jochen Sprickerhof Date: Tue, 25 Oct 2022 12:55:44 +0200 Subject: [PATCH] Support 0 as versionCode See: !1230 --- fdroidserver/metadata.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/fdroidserver/metadata.py b/fdroidserver/metadata.py index c6cc4b6b..9c08b584 100644 --- a/fdroidserver/metadata.py +++ b/fdroidserver/metadata.py @@ -965,16 +965,17 @@ def write_yaml(mf, app): build = Build(build) b = ruamel.yaml.comments.CommentedMap() for field in build_flags: - value = getattr(build, field) - if hasattr(build, field) and value: + if hasattr(build, field): + value = getattr(build, field) if field == 'gradle' and value == ['off']: value = [ruamel.yaml.scalarstring.SingleQuotedScalarString('off')] if field in ('maven', 'buildozer'): if value == 'no': continue - elif value == 'yes': - value = 'yes' - b.update({field: _field_to_yaml(flagtype(field), value)}) + typ = flagtype(field) + # don't check value == True for TYPE_INT as it could be 0 + if value is not None and (typ == TYPE_INT or value): + b.update({field: _field_to_yaml(typ, value)}) builds.append(b) # insert extra empty lines between build entries