From 58dcb4c2a0026e888dc6a3c04244236354fae920 Mon Sep 17 00:00:00 2001 From: Jochen Sprickerhof Date: Thu, 29 Jul 2021 10:45:41 +0200 Subject: [PATCH 1/2] [checkupdates] Don't fail for disabled apps --- fdroidserver/checkupdates.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fdroidserver/checkupdates.py b/fdroidserver/checkupdates.py index 510996c7..4ab9f854 100644 --- a/fdroidserver/checkupdates.py +++ b/fdroidserver/checkupdates.py @@ -434,7 +434,8 @@ def checkupdates_app(app): elif mode == 'HTTP': (version, vercode) = check_http(app) elif mode in ('None', 'Static'): - raise MetaDataException(_('Checking disabled')) + logging.debug('Checking disabled') + return else: raise MetaDataException(_('Invalid UpdateCheckMode: {mode}').format(mode=mode)) From 16f8d50194bb9d051bfd48cfdb74e749108335ff Mon Sep 17 00:00:00 2001 From: Jochen Sprickerhof Date: Thu, 29 Jul 2021 11:38:15 +0200 Subject: [PATCH 2/2] [checkupdates] make no version information an error --- fdroidserver/checkupdates.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fdroidserver/checkupdates.py b/fdroidserver/checkupdates.py index 4ab9f854..9b0a0bb4 100644 --- a/fdroidserver/checkupdates.py +++ b/fdroidserver/checkupdates.py @@ -456,7 +456,7 @@ def checkupdates_app(app): updating = False if version is None: - logging.warning('no version information found for {appid}'.format(appid=app.id)) + raise FDroidException(_('no version information found')) elif vercode == app.CurrentVersionCode: logging.debug("...up to date") elif int(vercode) > int(app.CurrentVersionCode):