kamp/fdroidserver
1
0
Fork 0
mirror of https://gitlab.com/fdroid/fdroidserver.git synced 2024-11-14 02:50:12 +01:00
Code Activity

checkupdates: avoid crash with --auto and None CVC

Browse Source 
Reproducible via `fdroid checkupdates --auto subreddit.android.appstore`
at fdroiddata HEAD (e76449ab).

WARNING: ...subreddit.android.appstore : Couldn't find package ID
CRITICAL: Unknown exception found!
Traceback (most recent call last):
  File "/home/mvdan/.bin/fdroid", line 147, in <module>
    main()
  File "/home/mvdan/.bin/fdroid", line 124, in main
    mod.main()
  File "/home/mvdan/git/fsr/fdroidserver/checkupdates.py", line 571, in main
    checkupdates_app(app)
  File "/home/mvdan/git/fsr/fdroidserver/checkupdates.py", line 469, in checkupdates_app
    if int(build.vercode) >= int(app.CurrentVersionCode):
TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'
This commit is contained in:
Daniel Martí 2016-09-26 21:07:55 +01:00
parent 7cbdaedf2e
commit bcd31401ac
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fdroidserver/checkupdates.py
View File

@ -452,7 +452,9 @@ def checkupdates_app(app, first=True):
if options.auto:
mode = app.AutoUpdateMode
if mode in ('None', 'Static'):
if not app.CurrentVersionCode:
logging.warn("Can't auto-update app with no current version code: " + app.id)
elif mode in ('None', 'Static'):
pass
elif mode.startswith('Version '):
pattern = mode[8:]