From 51ef9a8a99b99c250c196ad86be0a28d8bb51207 Mon Sep 17 00:00:00 2001 From: Marcus Hoffmann Date: Fri, 13 Jul 2018 17:00:45 +0200 Subject: [PATCH 1/3] gradlew-fdroid; print which gradle binary is actually running --- gradlew-fdroid | 1 + 1 file changed, 1 insertion(+) diff --git a/gradlew-fdroid b/gradlew-fdroid index a4223b61..151f6fe6 100755 --- a/gradlew-fdroid +++ b/gradlew-fdroid @@ -17,6 +17,7 @@ run_gradle() { if [ ! -d "${gradle_version_dir}/${v_found}" ]; then download_gradle ${v_found} fi + echo "Running ${gradle_version_dir}/${v_found}/bin/gradle ${args[@]}" "${gradle_version_dir}/${v_found}/bin/gradle" "${args[@]}" exit $? } From 03e9fe4b38796ff633764bd8acc31d785b48854c Mon Sep 17 00:00:00 2001 From: Marcus Hoffmann Date: Fri, 13 Jul 2018 17:01:14 +0200 Subject: [PATCH 2/3] gradlew-fdroid: save downloads with proper name This makes re-using them for makebuildserver possible --- gradlew-fdroid | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gradlew-fdroid b/gradlew-fdroid index 151f6fe6..d5261a1a 100755 --- a/gradlew-fdroid +++ b/gradlew-fdroid @@ -42,8 +42,8 @@ download_gradle() { else tmpdir=$(mktemp -d) fi - curl -o "${tmpdir}/gradle.zip" --silent --fail --show-error --location "${URL}" - gradle_zip="${tmpdir}/gradle.zip" + curl -o "${tmpdir}/gradle-$1-bin.zip" --silent --fail --show-error --location "${URL}" + gradle_zip="${tmpdir}/gradle-$1-bin.zip" fi echo "${shasum} ${gradle_zip}" | sha256sum -c - if [ $? != 0 ]; then From 7023f372fd7a159523c68d300c7ddf79fd1ed9ac Mon Sep 17 00:00:00 2001 From: Marcus Hoffmann Date: Fri, 13 Jul 2018 17:02:48 +0200 Subject: [PATCH 3/3] gradlew-fdroid: tabs -> spaces We have everything indented with spaces. Don't make an exception for shell scripts. --- gradlew-fdroid | 94 +++++++++++++++++++++++++------------------------- 1 file changed, 47 insertions(+), 47 deletions(-) diff --git a/gradlew-fdroid b/gradlew-fdroid index d5261a1a..5a3cd6af 100755 --- a/gradlew-fdroid +++ b/gradlew-fdroid @@ -18,8 +18,8 @@ run_gradle() { download_gradle ${v_found} fi echo "Running ${gradle_version_dir}/${v_found}/bin/gradle ${args[@]}" - "${gradle_version_dir}/${v_found}/bin/gradle" "${args[@]}" - exit $? + "${gradle_version_dir}/${v_found}/bin/gradle" "${args[@]}" + exit $? } download_gradle() { @@ -112,11 +112,11 @@ get_sha() { } contains() { - local e - for e in $2; do - [[ $e == $1 ]] && return 0; - done - return 1 + local e + for e in $2; do + [[ $e == $1 ]] && return 0; + done + return 1 } # key-value pairs of what gradle version (value) each gradle plugin version @@ -133,66 +133,66 @@ v_all=${plugin_v[@]} # Earliest takes priority for f in {.,..}/gradle/wrapper/gradle-wrapper.properties; do - [[ -f $f ]] || continue - while read l; do - if [[ $l == 'distributionUrl='* ]]; then - wrapper_ver=$(echo -n "$l" | sed "s/.*gradle-\\([0-9\\.\\+]\\+\\).*/\\1/") - fi - done < $f + [[ -f $f ]] || continue + while read l; do + if [[ $l == 'distributionUrl='* ]]; then + wrapper_ver=$(echo -n "$l" | sed "s/.*gradle-\\([0-9\\.\\+]\\+\\).*/\\1/") + fi + done < $f done if [[ -n $wrapper_ver ]]; then - v_found=$wrapper_ver - echo "Found $v_found via distributionUrl" - run_gradle + v_found=$wrapper_ver + echo "Found $v_found via distributionUrl" + run_gradle fi # Earliest takes priority for f in {.,..}/build.gradle; do - [[ -f $f ]] || continue - while read l; do - if [[ -z "$plugin_pver" && $l == *'com.android.tools.build:gradle:'* ]]; then - plugin_pver=$(echo -n "$l" | sed "s/.*com.android.tools.build:gradle:\\([0-9\\.\\+]\\+\\).*/\\1/") - elif [[ -z "$wrapper_ver" && $l == *'gradleVersion = '* ]]; then - wrapper_ver=$(echo -n "$l" | sed "s/.*gradleVersion *=* *[\"']\\([0-9\\.]\\+\\)[\"'].*/\\1/") - fi - done < $f + [[ -f $f ]] || continue + while read l; do + if [[ -z "$plugin_pver" && $l == *'com.android.tools.build:gradle:'* ]]; then + plugin_pver=$(echo -n "$l" | sed "s/.*com.android.tools.build:gradle:\\([0-9\\.\\+]\\+\\).*/\\1/") + elif [[ -z "$wrapper_ver" && $l == *'gradleVersion = '* ]]; then + wrapper_ver=$(echo -n "$l" | sed "s/.*gradleVersion *=* *[\"']\\([0-9\\.]\\+\\)[\"'].*/\\1/") + fi + done < $f done if [[ -n $wrapper_ver ]]; then - v_found=$wrapper_ver - echo "Found $v_found via gradleVersion" - run_gradle + v_found=$wrapper_ver + echo "Found $v_found via gradleVersion" + run_gradle fi if [[ -n $plugin_pver ]]; then - i=0 - match=false - for k in ${d_plugin_k[@]}; do - if [[ $plugin_pver == ${k}* ]]; then - plugin_ver=${d_plugin_v[$i]} - match=true - break - fi - let i++ - done - if $match; then - v_found=$plugin_ver - echo "Found $v_found via gradle plugin version $k" - fi + i=0 + match=false + for k in ${d_plugin_k[@]}; do + if [[ $plugin_pver == ${k}* ]]; then + plugin_ver=${d_plugin_v[$i]} + match=true + break + fi + let i++ + done + if $match; then + v_found=$plugin_ver + echo "Found $v_found via gradle plugin version $k" + fi fi # Find the highest version available for v in ${plugin_v[*]}; do - if contains $v "${v_all[*]}"; then - v_def=$v - break - fi + if contains $v "${v_all[*]}"; then + v_def=$v + break + fi done if [[ -z $v_found ]]; then - echo "No suitable gradle version found - defaulting to $v_def" - v_found=$v_def + echo "No suitable gradle version found - defaulting to $v_def" + v_found=$v_def fi run_gradle