From beb17ad84a763a764bcc51c7895853d331364a88 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Wed, 3 Jun 2015 15:52:46 +0200 Subject: [PATCH] Don't use the commits feed as a changelog link in import If it's often not a replacement for a proper changelog, do not advise its usage. --- fdroidserver/import.py | 4 ---- fdroidserver/lint.py | 4 ---- 2 files changed, 8 deletions(-) diff --git a/fdroidserver/import.py b/fdroidserver/import.py index 5e0c6b02..fa9c0253 100644 --- a/fdroidserver/import.py +++ b/fdroidserver/import.py @@ -128,7 +128,6 @@ def main(): # Figure out what kind of project it is... projecttype = None issuetracker = None - changelog = None license = None website = url # by default, we might override it if url.startswith('git://'): @@ -144,7 +143,6 @@ def main(): sourcecode = url issuetracker = url + '/issues' website = "" - changelog = url + '/commits' elif url.startswith('https://gitlab.com/'): projecttype = 'gitlab' repo = url @@ -288,8 +286,6 @@ def main(): app['Source Code'] = sourcecode if issuetracker: app['Issue Tracker'] = issuetracker - if changelog: - app['Changelog'] = changelog if license: app['License'] = license app['Repo Type'] = repotype diff --git a/fdroidserver/lint.py b/fdroidserver/lint.py index 169dc147..d0dedecc 100644 --- a/fdroidserver/lint.py +++ b/fdroidserver/lint.py @@ -125,10 +125,6 @@ regex_pedantic = { (re.compile(r'.*github\.com/[^/]+/[^/]+/issues/.*'), "/issues is often enough on its own"), ], - 'Changelog': [ - (re.compile(r'.*commit.*', re.IGNORECASE), - "Not every commit log is suitable as change log"), - ], 'Summary': [ (re.compile(r'.*[a-z0-9][.!?][ $]'), "Punctuation should be avoided"),