From d1d257bef48a3b94d6662312efa056909cde96ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Tue, 14 Apr 2015 14:18:44 +0200 Subject: [PATCH] lint: add commented out warnings about google code --- fdroidserver/lint.py | 30 ++++++++++++------------------ 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/fdroidserver/lint.py b/fdroidserver/lint.py index 4f17914a..9a1659ba 100644 --- a/fdroidserver/lint.py +++ b/fdroidserver/lint.py @@ -31,24 +31,22 @@ regex_warnings = { 'Web Site': [ (re.compile(r'.*[^sS]://github\.com/.*'), "github URLs should always use https:// not http://"), - (re.compile(r'.*[^sS]://code\.google\.com/.*'), - "code.google.com URLs should always use https:// not http://"), + # TODO enable in August 2015, when Google Code goes read-only + # (re.compile(r'.*://code\.google\.com/.*'), + # "code.google.com will be soon switching down, perhaps it moved to github.com?"), ], 'Source Code': [ (re.compile(r'.*[^sS]://github\.com/.*'), "github URLs should always use https:// (not http://, git://, or git@)"), - (re.compile(r'.*code\.google\.com/p/[^/]+[/]*$'), - "/source is missing"), - (re.compile(r'.*[^sS]://code\.google\.com/.*'), - "code.google.com URLs should always use https:// not http://"), (re.compile(r'.*[^sS]://dl\.google\.com/.*'), "dl.google.com URLs should always use https:// not http://"), (re.compile(r'.*[^sS]://gitorious\.org/.*'), "gitorious URLs should always use https:// (not http://, git://, or git@)"), + # TODO enable in August 2015, when Google Code goes read-only + # (re.compile(r'.*://code\.google\.com/.*'), + # "code.google.com will be soon switching down, perhaps it moved to github.com?"), ], 'Repo': [ - (re.compile(r'.*[^sS]://code\.google\.com/.*'), - "code.google.com URLs should always use https:// not http://"), (re.compile(r'.*[^sS]://dl\.google\.com/.*'), "dl.google.com URLs should always use https:// not http://"), (re.compile(r'.*[^sS]://github\.com/.*'), @@ -61,18 +59,20 @@ regex_warnings = { "Apache SVN URLs should always use https:// (not http:// or svn://)"), (re.compile(r'.*[^sS]://svn\.code\.sf\.net/.*'), "Sourceforge SVN URLs should always use https:// (not http:// or svn://)"), + # TODO enable in August 2015, when Google Code goes read-only + # (re.compile(r'.*://code\.google\.com/.*'), + # "code.google.com will be soon switching down, perhaps it moved to github.com?"), ], 'Issue Tracker': [ - (re.compile(r'.*code\.google\.com/p/[^/]+[/]*$'), - "/issues is missing"), - (re.compile(r'.*[^sS]://code\.google\.com/.*'), - "code.google.com URLs should always use https:// not http://"), (re.compile(r'.*github\.com/[^/]+/[^/]+[/]*$'), "/issues is missing"), (re.compile(r'.*[^sS]://github\.com/.*'), "github URLs should always use https:// not http://"), (re.compile(r'.*[^sS]://gitorious\.org/.*'), "gitorious URLs should always use https:// not http://"), + # TODO enable in August 2015, when Google Code goes read-only + # (re.compile(r'.*://code\.google\.com/.*'), + # "code.google.com will be soon switching down, perhaps it moved to github.com?"), ], 'License': [ (re.compile(r'^(|None|Unknown)$'), @@ -98,14 +98,10 @@ regex_pedantic = { 'Web Site': [ (re.compile(r'.*github\.com/[^/]+/[^/]+\.git'), "Appending .git is not necessary"), - (re.compile(r'.*code\.google\.com/p/[^/]+/[^w]'), - "Possible incorrect path appended to google code project site"), ], 'Source Code': [ (re.compile(r'.*github\.com/[^/]+/[^/]+\.git'), "Appending .git is not necessary"), - (re.compile(r'.*code\.google\.com/p/[^/]+/source/.*'), - "/source is often enough on its own"), ], 'Repo': [ (re.compile(r'^http://.*'), @@ -114,8 +110,6 @@ regex_pedantic = { "use https:// if available"), ], 'Issue Tracker': [ - (re.compile(r'.*code\.google\.com/p/[^/]+/issues/.*'), - "/issues is often enough on its own"), (re.compile(r'.*github\.com/[^/]+/[^/]+/issues/.*'), "/issues is often enough on its own"), ],