mirror of
https://gitlab.com/fdroid/fdroidserver.git
synced 2024-09-11 15:13:27 +02:00
scanner: use a blacklist instead of a whitelist
This is much closer to what we did before with mimetypes. Using a whitelist turns out to be a bad idea since repositories seem to be randomly filled with executable images and documents, which trigger the scanner. In an ideal world the scanner would complain about all of those. For now, just warn about the possibility of them being hidden binaries.
This commit is contained in:
parent
feaf3d04e5
commit
d7d9e38ef7
@ -160,18 +160,13 @@ def scan_source(build_dir, root_dir, thisbuild):
|
||||
for name in suspects_found(line):
|
||||
count += handleproblem('usual supect \'%s\' at line %d' % (name, i), fd, fp)
|
||||
|
||||
# These files are often found - avoid checking if they are binary
|
||||
# to speed up the scanner
|
||||
elif ext in [
|
||||
'xml', 'md', 'txt', 'html', 'sh', 'png', 'jpg',
|
||||
'ttf', 'otf']:
|
||||
pass
|
||||
elif ext in ['', 'bin', 'out', 'exe']:
|
||||
if is_binary(fp):
|
||||
count += handleproblem('binary', fd, fp)
|
||||
|
||||
elif is_binary(fp):
|
||||
if is_executable(fp):
|
||||
count += handleproblem('executable binary', fd, fp)
|
||||
elif ext == '':
|
||||
count += handleproblem('unknown binary', fd, fp)
|
||||
elif is_executable(fp):
|
||||
if is_binary(fp):
|
||||
warnproblem('possible binary', fd)
|
||||
|
||||
for p in scanignore:
|
||||
if p not in scanignore_worked:
|
||||
|
Loading…
Reference in New Issue
Block a user