kamp/fdroidserver
1
0
Fork 0
mirror of https://gitlab.com/fdroid/fdroidserver.git synced 2024-09-11 23:23:27 +02:00
Code Activity

Keep track of what attrs were modified in apps/builds

Browse Source 
This allows us to run checks and fix types only on those that were
really modified. On our fdroiddata repo, with 2k apps with many unset
fields and flags, this reduces readmeta runtime from ~1.3s to ~1.1s.
This commit is contained in:
Daniel Martí 2015-12-03 16:46:21 +01:00
parent 8c2e1fedfc
commit ea99add3da
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
fdroidserver/metadata.py
View File

@ -137,6 +137,7 @@ class App():
self.comments = {} self.comments = {}
self.added = None self.added = None
self.lastupdated = None self.lastupdated = None
self._modified = set()
# Translates human-readable field names to attribute names, e.g. # Translates human-readable field names to attribute names, e.g.
# 'Auto Name' to 'AutoName' # 'Auto Name' to 'AutoName'
@ -180,6 +181,7 @@ class App():
raise MetaDataException('Unrecognised app field: ' + f) raise MetaDataException('Unrecognised app field: ' + f)
k = App.field_to_attr(f) k = App.field_to_attr(f)
self.__dict__[k] = v self.__dict__[k] = v
self._modified.add(k)
# Appends to the value associated to a field name, e.g. 'Auto Name' # Appends to the value associated to a field name, e.g. 'Auto Name'
def append_field(self, f, v): def append_field(self, f, v):
@ -299,6 +301,8 @@ class Build():
self.antcommands = None self.antcommands = None
self.novcheck = False self.novcheck = False
self._modified = set()
def get_flag(self, f): def get_flag(self, f):
if f not in build_flags: if f not in build_flags:
raise MetaDataException('Unrecognised build flag: ' + f) raise MetaDataException('Unrecognised build flag: ' + f)
@ -312,6 +316,7 @@ class Build():
if f not in build_flags: if f not in build_flags:
raise MetaDataException('Unrecognised build flag: ' + f) raise MetaDataException('Unrecognised build flag: ' + f)
self.__dict__[f] = v self.__dict__[f] = v
self._modified.add(f)
def append_flag(self, f, v): def append_flag(self, f, v):
if f not in build_flags: if f not in build_flags:
@ -836,12 +841,16 @@ esc_newlines = re.compile(r'\\( |\n)')
def post_metadata_parse(app): def post_metadata_parse(app):
for k, v in app.__dict__.iteritems(): for k, v in app.__dict__.iteritems():
if k not in app._modified:
continue
if type(v) in (float, int): if type(v) in (float, int):
app.__dict__[k] = str(v) app.__dict__[k] = str(v)
for build in app.builds: for build in app.builds:
for k, v in build.__dict__.iteritems(): for k, v in build.__dict__.iteritems():
if k not in build._modified:
continue
if type(v) in (float, int): if type(v) in (float, int):
build.__dict__[k] = str(v) build.__dict__[k] = str(v)
continue continue