From fe22958476cf53169800e53c8d96875d677cdcfb Mon Sep 17 00:00:00 2001
From: Hans-Christoph Steiner <hans@eds.org>
Date: Wed, 25 May 2022 09:44:39 +0200
Subject: [PATCH] run-tests: skip tests that require apksigner when running on
 Java8

The buildserver VM has not been upgraded yet to bullseye, so it is still on
Debian/stretch.  The buildserver VM does not need to run `fdroid update`,
`fdroid signindex`, etc. so this new apksigner requirement should not
affect app builds even though they are stuck on Debian/stretch.
---
 tests/run-tests          | 11 +++++++++++
 tests/signindex.TestCase |  2 ++
 tests/update.TestCase    |  2 ++
 3 files changed, 15 insertions(+)

diff --git a/tests/run-tests b/tests/run-tests
index 59fb08e5..408c72a2 100755
--- a/tests/run-tests
+++ b/tests/run-tests
@@ -202,6 +202,17 @@ if use_apksigner; then
     grep -F '<application id=' repo/index.xml > /dev/null
 fi
 
+
+#------------------------------------------------------------------------------#
+echo_header "TODO remove once buildserver image is upgraded to bullseye with apksigner"
+
+if java -version 2>&1 | grep -F 1.8.0; then
+    echo "Skipping the rest because they require apksigner 30.0.0+ which does not run on Java8"
+    echo SUCCESS
+    exit
+fi
+
+
 #------------------------------------------------------------------------------#
 echo_header "test UTF-8 metadata"
 
diff --git a/tests/signindex.TestCase b/tests/signindex.TestCase
index f51d7e11..63fac860 100755
--- a/tests/signindex.TestCase
+++ b/tests/signindex.TestCase
@@ -70,6 +70,8 @@ class SignindexTest(unittest.TestCase):
             signindex.sign_index(str(self.repodir), 'index-v1.json')
 
     def test_signindex(self):
+        if common.find_apksigner({}) is None:  # TODO remove me for buildserver-bullseye
+            self.skipTest('SKIPPING test_signindex, apksigner not installed!')
         os.mkdir('archive')
         metadata = Path('metadata')
         metadata.mkdir()
diff --git a/tests/update.TestCase b/tests/update.TestCase
index 1c2d3d95..6428dce2 100755
--- a/tests/update.TestCase
+++ b/tests/update.TestCase
@@ -1165,6 +1165,8 @@ class UpdateTest(unittest.TestCase):
 
         fdroidserver.common.options = Options
         config = fdroidserver.common.read_config(fdroidserver.common.options)
+        if 'apksigner' not in config:  # TODO remove me for buildserver-bullseye
+            self.skipTest('SKIPPING test_update_with_AllowedAPKSigningKeys, apksigner not installed!')
         config['repo_keyalias'] = 'sova'
         config['keystorepass'] = 'r9aquRHYoI8+dYz6jKrLntQ5/NJNASFBacJh7Jv2BlI='
         config['keypass'] = 'r9aquRHYoI8+dYz6jKrLntQ5/NJNASFBacJh7Jv2BlI='