1
0
mirror of https://gitlab.com/fdroid/fdroidserver.git synced 2024-11-18 20:50:10 +01:00
Commit Graph

14 Commits

Author SHA1 Message Date
proletarius101
4b898287e9 make linting and formatting rules consistent 2023-05-04 14:12:08 +00:00
Hans-Christoph Steiner
6dcdadd0e3
config black exceptions in pyproject.toml
This means that anyone can run `black .` and it won't break things. Plus it
gives us a roadmap for fully enabling black.
2023-04-27 11:34:19 +02:00
Hans-Christoph Steiner
9749b26baa pylint: Reenable C0201 consider-iterating-dictionary
* C0201: Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary)
2023-03-20 16:33:16 +01:00
FestplattenSchnitzel
a4c1ca48ad pylint: Reenable R1722 consider-using-sys-exit
* R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
2023-03-20 16:33:16 +01:00
Hans-Christoph Steiner
1fbfae355a pylint: Reenable R1723 no-else-break
* R1723: Unnecessary "elif" after "break", remove the leading "el" from "elif" (no-else-break)
2023-03-20 16:33:16 +01:00
FestplattenSchnitzel
abc752314b pylint: Reenable E1101 no-member 2023-03-20 16:33:16 +01:00
FestplattenSchnitzel
1dcb863f55 pylint: Set Python version, exclude vendored file 2023-03-20 16:33:16 +01:00
Hans-Christoph Steiner
bf5e65dd24 pylint: hide broad-exception-caught and broad-exception-raised
I suppose it would be nice to have these enabled, but yeah...
2023-03-20 14:43:44 +01:00
Hans-Christoph Steiner
4282d34343 gitlab-ci: port lint_* job to Debian/bookworm for stability
This saves us from being surprised by new rules in pylint, pyflakes, etc
like:
https://gitlab.com/FestplattenSchnitzel/fdroidserver/-/jobs/3895256515
2023-03-09 11:45:02 +01:00
Hans-Christoph Steiner
497fcfc848 silence new pylint checks that are too much for the current state
Ideally, these would be fixed.  But it'll be a project.

* C0201: Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary)
* R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
* R1720: Unnecessary "elif" after "raise", remove the leading "el" from "elif" (no-else-raise)
* R1720: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it (no-else-raise)
* R1722: Consider using 'sys.exit' instead (consider-using-sys-exit)
* R1723: Unnecessary "elif" after "break", remove the leading "el" from "elif" (no-else-break)
* R1724: Unnecessary "elif" after "continue", remove the leading "el" from "elif" (no-else-continue)
* R1735: Consider using '{}' instead of a call to 'dict'. (use-dict-literal)
* W0133: Exception statement has no effect (pointless-exception-statement)
* W0718: Catching too general exception Exception (broad-exception-caught)
* W0719: Raising too general exception: Exception (broad-exception-raised)
* W1510: 'subprocess.run' used without explicitly defining the value for 'check'. (subprocess-run-check)
2023-02-02 16:13:54 +01:00
Hans-Christoph Steiner
e799f32d71 set black to format to py38 to support Debian/bullseye package
Debian/bullseye (stable) includes black v20.8b1, which does not yet know
about the py39 target-version.
2022-10-31 10:19:43 +01:00
FestplattenSchnitzel
625dc11930 Require Python 3.9 2022-10-24 09:17:27 +00:00
FestplattenSchnitzel
e4d16ec1e8 Move lint tools configuration to pyproject.toml
This commit removes the mypy CI job, since there are no or few type
hints in the codebase and it failed on unrelated changes in the past.
It might be reintroduced when type hints get added.
2022-09-30 17:53:31 +00:00
linsui
466c8a44d7 add vscode settings 2021-06-18 06:50:50 +00:00