kamp/fdroidserver
1
0
Fork 0
mirror of https://gitlab.com/fdroid/fdroidserver.git synced 2024-11-04 22:40:12 +01:00
Code Activity
5,054 Commits 1 Branch 59 Tags 40 MiB
ea3f9df473
Commit Graph

5054 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Hans-Christoph Steiner
a1075f45cc git-svn: require working HTTPS for all Subversion URLs 
Subversion does not verify each commit as strongly as git does, so HTTPS is
really important.  Also, there is the possibility of injecting code into
`fdroid checkupdate` calls if plain HTTP is used.
 2018-02-12 12:07:24 +01:00
Hans-Christoph Steiner
dd93ee6c9b git: use /bin/true for 'askpass' to prevent all password prompts 
This uses both the env vars and the command line options to ensure
that it works with as many versions of git as possible.  Also, git-svn
uses the env vars, but not necessarily the command line options.

This uses /bin/true to pretend that it succesfully got the password.
If password auth is truly required, then it will fail further on down
the line.
 2018-02-12 12:07:24 +01:00
Hans-Christoph Steiner
574fa15fce git: make explicit that git configs are calling cmd line utilities 
These are not boolean values, but command line utilities which return a
guaranteed exit status.
 2018-02-12 12:07:24 +01:00
Hans-Christoph Steiner
c67ed5e85f git-svn: use '--' to isolate user input in command lines 2018-02-12 12:07:24 +01:00
Hans-Christoph Steiner
62db94d96e Merge branch 'build-36h' into 'master' 
build: set overall timeout to 36 hours

See merge request fdroid/fdroidserver!460
 2018-02-12 11:06:34 +00:00
Hans-Christoph Steiner
a40b79eb9d import: fix crash when importing from local git repo 2018-02-12 12:05:27 +01:00
Hans-Christoph Steiner
559adb207b import: get build dir from settings.gradle 
Most projects set a single build dir in settings.gradle, so its worth
trying here.
 2018-02-12 12:05:27 +01:00
Hans-Christoph Steiner
64938d9104 import: switch to .yml as default metadata format 2018-02-12 12:05:27 +01:00
Hans-Christoph Steiner
d4e64bda4c Merge branch 'timeout_flag' into 'master' 
build: clear timeout flag before every build

See merge request fdroid/fdroidserver!455
 2018-02-12 12:01:46 +01:00
Hans-Christoph Steiner
2238b5cafd Merge branch 'metadata-write-int' into 'master' 
metadata: write values of TYPE_INT fields

See merge request fdroid/fdroidserver!456
 2018-02-12 10:57:38 +00:00
Hans-Christoph Steiner
ef9b89f4ec Merge branch 'remove-ndk-r9b' into 'master' 
makebuildserver: remove NDK r9b to save 1.6 GB of disk space

See merge request fdroid/fdroidserver!459
 2018-02-12 10:55:02 +00:00
Hans-Christoph Steiner
8326e62235 Merge branch 'ndk-r16b' into 'master' 
makebuildserver: upgrade NDK r16 to r16b

See merge request fdroid/fdroidserver!458
 2018-02-12 10:54:31 +00:00
Hans-Christoph Steiner
9ba9c6cc3d Merge branch 'gradle-4.5.1' into 'master' 
makebuildserver: add Gradle 4.5.1

See merge request fdroid/fdroidserver!457
 2018-02-12 10:54:06 +00:00
relan
c0f323e343 build: set overall timeout to 36 hours 
Currently f-droid.org has a lot of pending builds and big delays
between "fdroid build --all" runs. Bump overall build time limit from
12 hours to 36 hours to increase buildserver throughput.
 2018-02-12 13:45:53 +03:00
relan
76da21f121 makebuildserver: remove NDK r9b to save 1.6 GB of disk space 
NDK r9b is used by only one app (net.gorry.android.input.nicownng) that
was last updated in 2015.
 2018-02-12 09:16:55 +03:00
relan
6f295cb3d3 makebuildserver: upgrade NDK r16 to r16b 2018-02-11 10:20:42 +03:00
relan
5387fe85a7 makebuildserver: add Gradle 4.5.1 2018-02-11 10:08:06 +03:00
relan
4d56c6c262 metadata: write values of TYPE_INT fields 
Otherwise we end up with empty values after "fdroid rewritemeta".
 2018-02-11 09:51:53 +03:00
Marcus Hoffmann
39a5637df2
build: clear timeout flag before every build 
This fixes the weird logging behaviour where after a build that timed
out all subsequent failed builds would also show up as timed out.
 2018-02-07 20:47:50 +01:00
Hans-Christoph Steiner
bc5bf7e0ec Merge branch 'translation-app-field' into 'master' 
metadata: add new Translation app field for URL for contributions

See merge request fdroid/fdroidserver!450
 2018-02-05 15:16:43 +00:00
Hans-Christoph Steiner
eac391c58f Merge branch 'popen-stdin-devnull' into 'master' 
common: use /dev/null as stdin when calling subprocess.Popen()

See merge request fdroid/fdroidserver!451
 2018-02-05 14:46:08 +00:00
Hans-Christoph Steiner
05eef5a454 metadata: add new Translation app field for URL for contributions 
This is a field requested from a bunch of translators so they can easily
find where to translate apps:
https://forum.f-droid.org/t/translation-field-for-app-entries/1403/5
 2018-02-05 15:45:12 +01:00
relan
946a1461f2 common: use /dev/null as stdin when calling subprocess.Popen() 
We always want to run all utilities non-interactively. By default
subprocess.Popen() inherits stdin descriptor from parent process, i.e.
when fdroid is run from an interactive shell, subprocesses may expect
input from it.

Reading from /dev/null immediately returns EOF, failing any user prompt
and preventing us from hang.
 2018-02-05 15:34:42 +03:00
Hans-Christoph Steiner
5db86215f6 lint: check srclibs has name and @ in it 
fdroiddata!2863
 2018-01-31 13:33:36 +01:00
Hans-Christoph Steiner
4b0f9d6653 Merge branch 'master' into 'master' 
Option --resetserver does nothing; have it used instead

See merge request fdroid/fdroidserver!449
 2018-01-31 10:01:18 +00:00
csagan5
427427481e Change --resetserver to --reset-server for consistency 2018-01-30 20:45:03 +01:00
csagan5
cf54c9514c Option --resetserver does nothing; have it used instead 2018-01-30 14:50:35 +01:00
Hans-Christoph Steiner
adaf97a3cb Merge branch 'build-timeout-customization' into 'master' 
build: make per-build hard time limit customizable

See merge request fdroid/fdroidserver!446
 2018-01-30 11:22:08 +01:00
Hans-Christoph Steiner
b170ef7ce8 fix metadata test: remove timeout= from comparison 2018-01-30 11:20:30 +01:00
relan
86f34ee70a build: make per-build hard time limit customizable 
Add "timeout=n" metadata field that overrides build timeout (in seconds).
The default is 7200, i.e. 2 hours.
 2018-01-30 11:14:50 +03:00
relan
cc4b57b10b Merge branch 'gradle-4.5' into 'master' 
makebuildserver: add gradle 4.5

See merge request fdroid/fdroidserver!448
 2018-01-30 06:12:32 +00:00
Marcus Hoffmann
bf8dd8f6c9
makebuildserver: add gradle 4.5 2018-01-29 18:03:14 +01:00
Hans-Christoph Steiner
84262cfead Merge branch 'crash-and-standard-imports' into 'master' 
Crash and standard imports

See merge request fdroid/fdroidserver!445
 2018-01-29 09:24:48 +00:00
Hans-Christoph Steiner
68099cdf1c Merge branch 'minor-security-ish-tweaks' into 'master' 
security-ish tweaks

See merge request fdroid/fdroidserver!442
 2018-01-29 09:23:25 +00:00
Hans-Christoph Steiner
f24cf7f71b vmtools: use standard imports: os.remove() 
The rest of the code uses os.remove()
 2018-01-26 10:18:42 +01:00
Hans-Christoph Steiner
4463bf238d vmtools: use standard imports: os.path.join() 
The rest of the code uses os.path.join()
 2018-01-26 10:18:42 +01:00
Hans-Christoph Steiner
099c98bc60 metadata: fix crash when there are duplicate metadata files 
The string had the variable 'appid' while the format() call had only the
variable 'path'.  This also standardizes on 'appid' like the rest of the
code.
 2018-01-26 10:18:42 +01:00
Hans-Christoph Steiner
d3caf09421 use standard User-Agent in check-fdroid-apk 2018-01-26 10:18:41 +01:00
Hans-Christoph Steiner
b851d49d24 shell=True is too dangerous to allow; there are unfiltered user inputs 
There are all sorts of unfiltered user inputs like tag and branch names in
source repos.  If those names are fed into popen calls that use shell=True,
that opens up a wide range of exploits.  All core operations should never
use shell=True.
 2018-01-26 10:18:41 +01:00
Hans-Christoph Steiner
07cdf848d7 use '--' in source vcs calls to protect against malicious input 
This is a quick and very incomplete addition of '--' to command line calls
to source VCSs like git and hg that could manipulated by malicious
tag/branch names or other vectors.

These were all manually tested by calling the command lines on my own
machine.
 2018-01-26 10:18:41 +01:00
Hans-Christoph Steiner
32213ef040 scanner: allow running without versionCode and as API 
This lets `fdroid scanner my.package.name` run without requiring that the
versionCode is also specified.  It also allows scanner.scan_source() to be
called as a function in the public API of fdroidserver.
 2018-01-26 10:18:41 +01:00
Hans-Christoph Steiner
53f603bf30 lint: check description for forbidden HTML tags: iframe, link, script, etc. 2018-01-26 10:18:41 +01:00
Hans-Christoph Steiner
f0940540ee buildserver: include python3-git for future use 
We should be replacing all our custom git shell commands with python3-git,
since it is a common library for doing that.  It will receive a lot more
attention and maintenance than our code for doing it.  For example, we
should not ever use shell=True, since that opens up a lot of security
risks.
 2018-01-26 10:18:41 +01:00
Hans-Christoph Steiner
a57f17b276 wiki: include per-app link to all related activity on gitlab.com 2018-01-26 10:18:41 +01:00
Hans-Christoph Steiner
528aa9269e Merge branch 'platform27' into 'master' 
makebuildserver: re-add platform 27

Closes #445

See merge request fdroid/fdroidserver!444
 2018-01-26 09:09:15 +00:00
Marcus Hoffmann
0e68971eef
makebuildserver: re-add platform 27 
Closes #445
 2018-01-25 16:56:56 +01:00
Marcus
9f6862ce82 Merge branch 'build_tools_27.0.3' into 'master' 
makebuildserver: add build-tools 27.0.3

See merge request fdroid/fdroidserver!443
 2018-01-25 13:12:53 +00:00
Marcus Hoffmann
98313fc066
makebuildserver: add build-tools 27.0.3 2018-01-25 11:53:27 +01:00
Hans-Christoph Steiner
a4bdd104d7 Merge branch 'remove-kivy' into 'master' 
build: remove unused, unmaintained Kivy build method

See merge request fdroid/fdroidserver!441
 2018-01-24 05:35:32 +00:00
Hans-Christoph Steiner
513c95894c build: remove unused, unmaintained Kivy build method 
This code has never been used and contains some insecure uses of shell=True
Building Kivy apps should be done with the buildozer=yes method.  The
buildozer method should probably be moved to a provisioner once that is in
place.
 2018-01-23 23:16:05 +01:00