From 966ce261cb4ad99efaadef5c36564fdfaed0d5c4 Mon Sep 17 00:00:00 2001 From: Elias Schneider Date: Sat, 11 Nov 2023 18:56:52 +0100 Subject: [PATCH] fix: reverse shares couldn't be created unauthenticated --- backend/src/share/guard/shareOwner.guard.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/backend/src/share/guard/shareOwner.guard.ts b/backend/src/share/guard/shareOwner.guard.ts index ae3e645..8a5f538 100644 --- a/backend/src/share/guard/shareOwner.guard.ts +++ b/backend/src/share/guard/shareOwner.guard.ts @@ -19,7 +19,6 @@ export class ShareOwnerGuard extends JwtGuard { } async canActivate(context: ExecutionContext) { - if (!(await super.canActivate(context))) return false; const request: Request = context.switchToHttp().getRequest(); const shareId = Object.prototype.hasOwnProperty.call( @@ -38,6 +37,8 @@ export class ShareOwnerGuard extends JwtGuard { if (!share.creatorId) return true; + if (!(await super.canActivate(context))) return false; + return share.creatorId == (request.user as User).id; } }