diff --git a/requirements-dev.txt b/requirements-dev.txt index a4ef3a948..4ab1e0c51 100644 --- a/requirements-dev.txt +++ b/requirements-dev.txt @@ -2,7 +2,7 @@ mock==4.0.3 nose2[coverage_plugin]==0.10.0 cov-core==1.15.0 pycodestyle==2.7.0 -pylint==2.8.3 +pylint==2.9.3 splinter==0.14.0 transifex-client==0.14.2 selenium==3.141.0 diff --git a/searx/preferences.py b/searx/preferences.py index b63bd446b..e4a2ebecd 100644 --- a/searx/preferences.py +++ b/searx/preferences.py @@ -179,7 +179,7 @@ class SearchLanguageSetting(EnumStringSetting): if data not in self.choices and data != self.value: # pylint: disable=no-member # hack to give some backwards compatibility with old language cookies data = str(data).replace('_', '-') - lang = data.split('-')[0] + lang = data.split('-', maxsplit=1)[0] # pylint: disable=no-member if data in self.choices: pass @@ -503,6 +503,7 @@ class Preferences: """Save cookie in the HTTP reponse obect """ for user_setting_name, user_setting in self.key_value_settings.items(): + # pylint: disable=unnecessary-dict-index-lookup if self.key_value_settings[user_setting_name].locked: continue user_setting.save(user_setting_name, resp) diff --git a/searx/search/checker/__main__.py b/searx/search/checker/__main__.py index 7a85347cc..e1de860b7 100644 --- a/searx/search/checker/__main__.py +++ b/searx/search/checker/__main__.py @@ -34,8 +34,16 @@ else: BLACK, RED, GREEN, YELLOW, BLUE, MAGENTA, CYAN, WHITE = "", "", "", "", "", "", "", "" # equivalent of 'python -u' (unbuffered stdout, stderr) -stdout = io.TextIOWrapper(open(sys.stdout.fileno(), 'wb', 0), write_through=True) -stderr = io.TextIOWrapper(open(sys.stderr.fileno(), 'wb', 0), write_through=True) +stdout = io.TextIOWrapper( + # pylint: disable=consider-using-with + open(sys.stdout.fileno(), 'wb', 0), + write_through=True +) +stderr = io.TextIOWrapper( + # pylint: disable=consider-using-with + open(sys.stderr.fileno(), 'wb', 0) + , write_through=True +) # iterator of processors diff --git a/searx/search/processors/__init__.py b/searx/search/processors/__init__.py index d5ebdb70c..b3d121f0e 100644 --- a/searx/search/processors/__init__.py +++ b/searx/search/processors/__init__.py @@ -17,7 +17,7 @@ __all__ = [ import threading from searx import logger -import searx.engines as engines +from searx import engines from .online import OnlineProcessor from .offline import OfflineProcessor diff --git a/searx/webapp.py b/searx/webapp.py index 6a3562c1c..4d838062b 100755 --- a/searx/webapp.py +++ b/searx/webapp.py @@ -433,6 +433,7 @@ def _get_ordered_categories(): def _get_enable_categories(all_categories): disabled_engines = request.preferences.engines.get_disabled() enabled_categories = set( + # pylint: disable=consider-using-dict-items category for engine_name in engines for category in engines[engine_name].categories if (engine_name, category) not in disabled_engines @@ -947,7 +948,8 @@ def preferences(): ) engines_by_category = {} - for c in categories: + + for c in categories: # pylint: disable=consider-using-dict-items engines_by_category[c] = [e for e in categories[c] if e.name in filtered_engines] # sort the engines alphabetically since the order in settings.yml is meaningless. list.sort(engines_by_category[c], key=lambda e: e.name)