mirror of
https://github.com/searxng/searxng.git
synced 2024-11-15 01:00:12 +01:00
44a06190bb
- for tests which perform the same arrange/act/assert pattern but with different data, the data portion has been moved to the ``paramaterized.expand`` fields - for monolithic tests which performed multiple arrange/act/asserts, they have been broken up into different unit tests. - when possible, change generic assert statements to more concise asserts (i.e. ``assertIsNone``) This work ultimately is focused on creating smaller and more concise tests. While paramaterized may make adding new configurations for existing tests easier, that is just a beneficial side effect. The main benefit is that smaller tests are easier to reason about, meaning they are easier to debug when they start failing. This improves the developer experience in debugging what went wrong when refactoring the project. Total number of tests went from 192 -> 259; or, broke apart larger tests into 69 more concise ones.
124 lines
4.7 KiB
Python
124 lines
4.7 KiB
Python
# SPDX-License-Identifier: AGPL-3.0-or-later
|
|
# pylint: disable=missing-module-docstring
|
|
|
|
from searx.external_bang import (
|
|
get_node,
|
|
resolve_bang_definition,
|
|
get_bang_url,
|
|
get_bang_definition_and_autocomplete,
|
|
LEAF_KEY,
|
|
)
|
|
from searx.search import SearchQuery, EngineRef
|
|
from tests import SearxTestCase
|
|
|
|
|
|
TEST_DB = {
|
|
'trie': {
|
|
'exam': {
|
|
'ple': '//example.com/' + chr(2) + chr(1) + '0',
|
|
LEAF_KEY: '//wikipedia.org/wiki/' + chr(2) + chr(1) + '0',
|
|
},
|
|
'sea': {
|
|
LEAF_KEY: 'sea' + chr(2) + chr(1) + '0',
|
|
'rch': {
|
|
LEAF_KEY: 'search' + chr(2) + chr(1) + '0',
|
|
'ing': 'searching' + chr(2) + chr(1) + '0',
|
|
},
|
|
's': {
|
|
'on': 'season' + chr(2) + chr(1) + '0',
|
|
'capes': 'seascape' + chr(2) + chr(1) + '0',
|
|
},
|
|
},
|
|
'error': ['error in external_bangs.json'],
|
|
}
|
|
}
|
|
|
|
|
|
class TestGetNode(SearxTestCase): # pylint: disable=missing-class-docstring
|
|
|
|
DB = { # pylint:disable=invalid-name
|
|
'trie': {
|
|
'exam': {
|
|
'ple': 'test',
|
|
LEAF_KEY: 'not used',
|
|
}
|
|
}
|
|
}
|
|
|
|
def test_found(self):
|
|
node, before, after = get_node(TestGetNode.DB, 'example')
|
|
|
|
self.assertEqual(node, 'test')
|
|
self.assertEqual(before, 'example')
|
|
self.assertEqual(after, '')
|
|
|
|
def test_get_partial(self):
|
|
node, before, after = get_node(TestGetNode.DB, 'examp')
|
|
self.assertEqual(node, TestGetNode.DB['trie']['exam'])
|
|
self.assertEqual(before, 'exam')
|
|
self.assertEqual(after, 'p')
|
|
|
|
def test_not_found(self):
|
|
node, before, after = get_node(TestGetNode.DB, 'examples')
|
|
self.assertEqual(node, 'test')
|
|
self.assertEqual(before, 'example')
|
|
self.assertEqual(after, 's')
|
|
|
|
|
|
class TestResolveBangDefinition(SearxTestCase): # pylint:disable=missing-class-docstring
|
|
def test_https(self):
|
|
url, rank = resolve_bang_definition('//example.com/' + chr(2) + chr(1) + '42', 'query')
|
|
self.assertEqual(url, 'https://example.com/query')
|
|
self.assertEqual(rank, 42)
|
|
|
|
def test_http(self):
|
|
url, rank = resolve_bang_definition('http://example.com/' + chr(2) + chr(1) + '0', 'text')
|
|
self.assertEqual(url, 'http://example.com/text')
|
|
self.assertEqual(rank, 0)
|
|
|
|
|
|
class TestGetBangDefinitionAndAutocomplete(SearxTestCase): # pylint:disable=missing-class-docstring
|
|
def test_found(self):
|
|
bang_definition, new_autocomplete = get_bang_definition_and_autocomplete('exam', external_bangs_db=TEST_DB)
|
|
self.assertEqual(bang_definition, TEST_DB['trie']['exam'][LEAF_KEY])
|
|
self.assertEqual(new_autocomplete, ['example'])
|
|
|
|
def test_found_optimized(self):
|
|
bang_definition, new_autocomplete = get_bang_definition_and_autocomplete('example', external_bangs_db=TEST_DB)
|
|
self.assertEqual(bang_definition, TEST_DB['trie']['exam']['ple'])
|
|
self.assertEqual(new_autocomplete, [])
|
|
|
|
def test_partial(self):
|
|
bang_definition, new_autocomplete = get_bang_definition_and_autocomplete('examp', external_bangs_db=TEST_DB)
|
|
self.assertIsNone(bang_definition)
|
|
self.assertEqual(new_autocomplete, ['example'])
|
|
|
|
def test_partial2(self):
|
|
bang_definition, new_autocomplete = get_bang_definition_and_autocomplete('sea', external_bangs_db=TEST_DB)
|
|
self.assertEqual(bang_definition, TEST_DB['trie']['sea'][LEAF_KEY])
|
|
self.assertEqual(new_autocomplete, ['search', 'searching', 'seascapes', 'season'])
|
|
|
|
def test_error(self):
|
|
bang_definition, new_autocomplete = get_bang_definition_and_autocomplete('error', external_bangs_db=TEST_DB)
|
|
self.assertIsNone(bang_definition)
|
|
self.assertEqual(new_autocomplete, [])
|
|
|
|
def test_actual_data(self):
|
|
bang_definition, new_autocomplete = get_bang_definition_and_autocomplete('duckduckgo')
|
|
self.assertTrue(bang_definition.startswith('//duckduckgo.com/?q='))
|
|
self.assertEqual(new_autocomplete, [])
|
|
|
|
|
|
class TestExternalBangJson(SearxTestCase): # pylint:disable=missing-class-docstring
|
|
def test_no_external_bang_query(self):
|
|
result = get_bang_url(SearchQuery('test', engineref_list=[EngineRef('wikipedia', 'general')]))
|
|
self.assertIsNone(result)
|
|
|
|
def test_get_bang_url(self):
|
|
url = get_bang_url(SearchQuery('test', engineref_list=[], external_bang='example'), external_bangs_db=TEST_DB)
|
|
self.assertEqual(url, 'https://example.com/test')
|
|
|
|
def test_actual_data(self):
|
|
google_url = get_bang_url(SearchQuery('test', engineref_list=[], external_bang='g'))
|
|
self.assertEqual(google_url, 'https://www.google.com/search?q=test')
|