kamp/fdroidserver
1
0
Fork 0
mirror of https://gitlab.com/fdroid/fdroidserver.git synced 2024-09-17 18:50:11 +02:00
Code Activity

lint: add commented out warnings about google code

Browse Source
This commit is contained in:
Daniel Martí 2015-04-14 14:18:44 +02:00
parent 4888339a9d
commit d1d257bef4
1 changed files with 12 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
fdroidserver/lint.py
View File

@ -31,24 +31,22 @@ regex_warnings = {
'Web Site': [ 'Web Site': [
(re.compile(r'.*[^sS]://github\.com/.*'), (re.compile(r'.*[^sS]://github\.com/.*'),
"github URLs should always use https:// not http://"), "github URLs should always use https:// not http://"),
(re.compile(r'.*[^sS]://code\.google\.com/.*'), # TODO enable in August 2015, when Google Code goes read-only
"code.google.com URLs should always use https:// not http://"), # (re.compile(r'.*://code\.google\.com/.*'),
# "code.google.com will be soon switching down, perhaps it moved to github.com?"),
], ],
'Source Code': [ 'Source Code': [
(re.compile(r'.*[^sS]://github\.com/.*'), (re.compile(r'.*[^sS]://github\.com/.*'),
"github URLs should always use https:// (not http://, git://, or git@)"), "github URLs should always use https:// (not http://, git://, or git@)"),
(re.compile(r'.*code\.google\.com/p/[^/]+[/]*$'),
"/source is missing"),
(re.compile(r'.*[^sS]://code\.google\.com/.*'),
"code.google.com URLs should always use https:// not http://"),
(re.compile(r'.*[^sS]://dl\.google\.com/.*'), (re.compile(r'.*[^sS]://dl\.google\.com/.*'),
"dl.google.com URLs should always use https:// not http://"), "dl.google.com URLs should always use https:// not http://"),
(re.compile(r'.*[^sS]://gitorious\.org/.*'), (re.compile(r'.*[^sS]://gitorious\.org/.*'),
"gitorious URLs should always use https:// (not http://, git://, or git@)"), "gitorious URLs should always use https:// (not http://, git://, or git@)"),
# TODO enable in August 2015, when Google Code goes read-only
# (re.compile(r'.*://code\.google\.com/.*'),
# "code.google.com will be soon switching down, perhaps it moved to github.com?"),
], ],
'Repo': [ 'Repo': [
(re.compile(r'.*[^sS]://code\.google\.com/.*'),
"code.google.com URLs should always use https:// not http://"),
(re.compile(r'.*[^sS]://dl\.google\.com/.*'), (re.compile(r'.*[^sS]://dl\.google\.com/.*'),
"dl.google.com URLs should always use https:// not http://"), "dl.google.com URLs should always use https:// not http://"),
(re.compile(r'.*[^sS]://github\.com/.*'), (re.compile(r'.*[^sS]://github\.com/.*'),
@ -61,18 +59,20 @@ regex_warnings = {
"Apache SVN URLs should always use https:// (not http:// or svn://)"), "Apache SVN URLs should always use https:// (not http:// or svn://)"),
(re.compile(r'.*[^sS]://svn\.code\.sf\.net/.*'), (re.compile(r'.*[^sS]://svn\.code\.sf\.net/.*'),
"Sourceforge SVN URLs should always use https:// (not http:// or svn://)"), "Sourceforge SVN URLs should always use https:// (not http:// or svn://)"),
# TODO enable in August 2015, when Google Code goes read-only
# (re.compile(r'.*://code\.google\.com/.*'),
# "code.google.com will be soon switching down, perhaps it moved to github.com?"),
], ],
'Issue Tracker': [ 'Issue Tracker': [
(re.compile(r'.*code\.google\.com/p/[^/]+[/]*$'),
"/issues is missing"),
(re.compile(r'.*[^sS]://code\.google\.com/.*'),
"code.google.com URLs should always use https:// not http://"),
(re.compile(r'.*github\.com/[^/]+/[^/]+[/]*$'), (re.compile(r'.*github\.com/[^/]+/[^/]+[/]*$'),
"/issues is missing"), "/issues is missing"),
(re.compile(r'.*[^sS]://github\.com/.*'), (re.compile(r'.*[^sS]://github\.com/.*'),
"github URLs should always use https:// not http://"), "github URLs should always use https:// not http://"),
(re.compile(r'.*[^sS]://gitorious\.org/.*'), (re.compile(r'.*[^sS]://gitorious\.org/.*'),
"gitorious URLs should always use https:// not http://"), "gitorious URLs should always use https:// not http://"),
# TODO enable in August 2015, when Google Code goes read-only
# (re.compile(r'.*://code\.google\.com/.*'),
# "code.google.com will be soon switching down, perhaps it moved to github.com?"),
], ],
'License': [ 'License': [
(re.compile(r'^(|None|Unknown)$'), (re.compile(r'^(|None|Unknown)$'),
@ -98,14 +98,10 @@ regex_pedantic = {
'Web Site': [ 'Web Site': [
(re.compile(r'.*github\.com/[^/]+/[^/]+\.git'), (re.compile(r'.*github\.com/[^/]+/[^/]+\.git'),
"Appending .git is not necessary"), "Appending .git is not necessary"),
(re.compile(r'.*code\.google\.com/p/[^/]+/[^w]'),
"Possible incorrect path appended to google code project site"),
], ],
'Source Code': [ 'Source Code': [
(re.compile(r'.*github\.com/[^/]+/[^/]+\.git'), (re.compile(r'.*github\.com/[^/]+/[^/]+\.git'),
"Appending .git is not necessary"), "Appending .git is not necessary"),
(re.compile(r'.*code\.google\.com/p/[^/]+/source/.*'),
"/source is often enough on its own"),
], ],
'Repo': [ 'Repo': [
(re.compile(r'^http://.*'), (re.compile(r'^http://.*'),
@ -114,8 +110,6 @@ regex_pedantic = {
"use https:// if available"), "use https:// if available"),
], ],
'Issue Tracker': [ 'Issue Tracker': [
(re.compile(r'.*code\.google\.com/p/[^/]+/issues/.*'),
"/issues is often enough on its own"),
(re.compile(r'.*github\.com/[^/]+/[^/]+/issues/.*'), (re.compile(r'.*github\.com/[^/]+/[^/]+/issues/.*'),
"/issues is often enough on its own"), "/issues is often enough on its own"),
], ],