Alberto <albertocanetedj@hotmail.com>
Allan Nordhøy <epost@anotheragency.no>
emma peel <emma.peel@riseup.net>
Laura Arjona Reina <larjona@larjona.net>
Markel <wakutiteo@protonmail.com>
Myeongjin Lee <aranet100@gmail.com>
Víctor Manuel Tapia Ramírez <victor-kratos-olympicp@hotmail.com>
$ ./hooks/pre-commit || export EXITVALUE=1
WARNING: ruby is not installed, using dummy placeholder!
fdroidserver/metadata.py:1180: use ==/!= to compare str, bytes, and int literals
fdroidserver/metadata.py:1184: use ==/!= to compare str, bytes, and int literals
fdroidserver/metadata.py:1186: use ==/!= to compare str, bytes, and int literals
fdroidserver/metadata.py:1189: use ==/!= to compare str, bytes, and int literals
ERROR: pyflakes tests failed!
Stop looking for the Gradle version if we found it via distributionUrl
in ./gradle/wrapper/gradle-wrapper.properties. If we go on to parsing
../gradle/wrapper/gradle-wrapper.properties, we'll erroneously get the
version from there.
Also, update the documentation comment to be absolutely clear.
The function used to copy images from any locale directory starting with at least two lowercase letters correctly, but only add those to the app metadata that started with two letters plus one big letter or a "-". The same problem did not exist for adding texts to the metadata.
buildserver: include build-tools 28.0.3
Added test aapt output files for build-tools 28.0.3
update.py: Still aapt output parsing, setting regex to catch 'name=' without prefixes, needed for build-tools 28.0.3
fdroid/fdroidserver!591
build-tools 28.0.3 added a new field in the end 'compileSdkVersionCodename=', which also accidentally ends with the string 'name='.
The purpose of this regex was to catch the 'packageName' field, which is in ht eaapt ouput the exact ' name=', therefore added whe non-caracter \W prefix match.
sample aapt output (28.0.3):
package: name='com.a.b.app' versionCode='1' versionName='1.0' compileSdkVersion='28' compileSdkVersionCodename='9'
previously, regex was catching second occurence, so '9'
See merge request !582
Traceback (most recent call last):
File "/builds/eighthave/fdroidserver/tests/build.TestCase", line 120, in test_get_apk_metadata
vc, vn = fdroidserver.build.get_metadata_from_apk(app, build, apkfilename)
File "/builds/eighthave/fdroidserver/fdroidserver/build.py", line 332, in get_metadata_from_apk
appid, versionCode, versionName = common.get_apk_id(apkfile)
File "/builds/eighthave/fdroidserver/fdroidserver/common.py", line 2126, in get_apk_id
return get_apk_id_androguard(apkfile)
File "/builds/eighthave/fdroidserver/fdroidserver/common.py", line 2158, in get_apk_id_androguard
while axml.is_valid():
AttributeError: 'AXMLParser' object has no attribute 'is_valid'
This has to do custom dict/encoder/decoder tricks in order to make sure
that each run of `fdroid verify` on the same files doesn't add duplicate
entries.
